From 7a872e5c8735f213e2832034571d2c86bf843263 Mon Sep 17 00:00:00 2001 From: Genitivo Date: Fri, 4 Aug 2017 18:05:39 +0200 Subject: [PATCH 1/2] Fix missing bracket --- .../com/charlires/segmentanalytics/SegmentAnalyticsModule.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/android/src/main/java/com/charlires/segmentanalytics/SegmentAnalyticsModule.java b/android/src/main/java/com/charlires/segmentanalytics/SegmentAnalyticsModule.java index 823d620..750e6cc 100644 --- a/android/src/main/java/com/charlires/segmentanalytics/SegmentAnalyticsModule.java +++ b/android/src/main/java/com/charlires/segmentanalytics/SegmentAnalyticsModule.java @@ -91,7 +91,8 @@ public void alias(String newId) { } catch (Exception e) { Log.e("SegmentAnalyticsModule", "Failed to alias " + newId + ". " + e.getMessage()); } - + } + private boolean nullOrEmpty(@Nullable ReadableMap readableMap) { return readableMap == null || !readableMap.keySetIterator().hasNextKey(); } From d668f7f70960ff94669745f60af2a1cd2c056efc Mon Sep 17 00:00:00 2001 From: Genitivo Date: Thu, 4 Jan 2018 17:16:06 +0100 Subject: [PATCH 2/2] remove @Override method that are deprecated since react-native 0.47 --- .../com/charlires/segmentanalytics/SegmentAnalyticsModule.java | 1 - .../charlires/segmentanalytics/SegmentAnalyticsPackage.java | 3 --- 2 files changed, 4 deletions(-) diff --git a/android/src/main/java/com/charlires/segmentanalytics/SegmentAnalyticsModule.java b/android/src/main/java/com/charlires/segmentanalytics/SegmentAnalyticsModule.java index 750e6cc..a28ac5a 100644 --- a/android/src/main/java/com/charlires/segmentanalytics/SegmentAnalyticsModule.java +++ b/android/src/main/java/com/charlires/segmentanalytics/SegmentAnalyticsModule.java @@ -26,7 +26,6 @@ public SegmentAnalyticsModule(ReactApplicationContext reactContext) { super(reactContext); } - @Override public String getName() { return "SegmentAnalytics"; } diff --git a/android/src/main/java/com/charlires/segmentanalytics/SegmentAnalyticsPackage.java b/android/src/main/java/com/charlires/segmentanalytics/SegmentAnalyticsPackage.java index 8405e73..48ab0b9 100644 --- a/android/src/main/java/com/charlires/segmentanalytics/SegmentAnalyticsPackage.java +++ b/android/src/main/java/com/charlires/segmentanalytics/SegmentAnalyticsPackage.java @@ -20,17 +20,14 @@ public class SegmentAnalyticsPackage implements ReactPackage { - @Override public List createNativeModules(ReactApplicationContext reactContext) { return Arrays.asList(new SegmentAnalyticsModule(reactContext)); } - @Override public List> createJSModules() { return Collections.emptyList(); } - @Override public List createViewManagers(ReactApplicationContext reactContext) { return Collections.emptyList(); }