Various README improvements #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hpk42
reviewed
Mar 25, 2025
feld
force-pushed
the
readme-improvements
branch
from
e1d3ffa to
4657a05
Compare
- e-mail -> email - capitalization of software and protocols (Postfix, Dovecot, SMTP, etc) Rephrased the install instructions to start by recommending the DNS records that cmdeploy is going to check for immediately anyway. Refactored the migration guide to fix incorrect tar commands (wrong usage of -C flag) and suggest how to copy directly from server to server by logging in with SSH agent forwarding. The mail services should be disabled first before proceeding with any changes and also ensure the echobot and mail spool are copied over to the new server so no messages are lost.
Co-authored-by: holger krekel <[email protected]>
Co-authored-by: holger krekel <[email protected]>
feld
force-pushed
the
readme-improvements
branch
from
0da33bd to
365757d
Compare
|
I think all of the discussed changes have been integrated. Please check the diffs and give another review. |
hpk42
approved these changes
Mar 26, 2025
There was a problem hiding this comment.
ok, thanks! we typically write "e-mail" instead of email but i'll approve and merge anyway to not drag this review/merge too long.
One thing that maybe @missytake can verify is if the "migration" guide is still fitting (the previous one was manually tested).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chatmail -> ChatmailRephrased the install instructions to start by recommending the DNS records that cmdeploy is going to check for immediately anyway.
Refactored the migration guide to fix incorrect tar commands (wrong usage of -C flag) and suggest how to copy directly from server to server by logging in with SSH agent forwarding. The mail services should be disabled first before proceeding with any changes and also ensure the echobot and mail spool are copied over to the new server so no messages are lost.