Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Adding translations to Optics workbench and using crowdin to manage them #52

Closed
luzpaz opened this issue Sep 11, 2024 · 10 comments

Comments

@luzpaz
Copy link
Contributor

luzpaz commented Sep 11, 2024

@chbergmann We're trying to get popular workbenches translated and into crowdin

Any interest in that ?

/cc @kaktusus & @hasecilu

@kaktusus
Copy link

If your workbench is ready for translation, we can help you handle translations on the Crowdin platform.

@chbergmann
Copy link
Owner

I can do that when I have time.

@hasecilu
Copy link
Contributor

Check my PRs on Render and CfdOF WBs, there is implemented the translation support in the correct way.

@luzpaz
Copy link
Contributor Author

luzpaz commented Dec 3, 2024

What's the status here ?

@chbergmann
Copy link
Owner

translations for German and Chinese have been added

@luzpaz
Copy link
Contributor Author

luzpaz commented Dec 4, 2024

I only see the german translations in https://github.com/chbergmann/OpticsWorkbench/blob/main/translations/

Also, is there a reason you're keeping the .qm file ?

Are you planning to use Crowdin, like other workbenches are ?

@hasecilu
Copy link
Contributor

hasecilu commented Dec 4, 2024

Also it's good idea to include the agnostic file (a clean file with no locale and no translations) for people that wants to also translate it.

@chbergmann
Copy link
Owner

I only see the german translations in https://github.com/chbergmann/OpticsWorkbench/blob/main/translations/
Chinese files have been added

Also, is there a reason you're keeping the .qm file ?
Yes, they are needed to display the selected language. qm files are not generated automatically if somebody installs the Optics workbench.

Are you planning to use Crowdin, like other workbenches are ?
I asked Yorik again for access to the FreeCAD-addons project. Once I got it I will do.

@chbergmann
Copy link
Owner

The agnostic file got lost, but anybody can use

Also it's good idea to include the agnostic file (a clean file with no locale and no translations) for people that wants to also translate it.
I do not have one. But it is also easy to use any file in another language and exchange the translations. Or use crowdin once I got access and uploded the translations.

@hasecilu hasecilu mentioned this issue Dec 7, 2024
1 task
@hasecilu
Copy link
Contributor

hasecilu commented Dec 8, 2024

This WB has been added to CrowdIn, translations synced.

@luzpaz luzpaz closed this as completed Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants