Fixed syntax

Author: chiacyu

hadoop-hdds/client/src/test/java/org/apache/hadoop/hdds/scm/storage/DummyBlockInputStreamWithRetry.java

@@ -63,7 +63,7 @@ final class DummyBlockInputStreamWithRetry
           try {
             BlockLocationInfo blockLocationInfo = mock(BlockLocationInfo.class);
             Pipeline mockPipeline = MockPipeline.createPipeline(1);
-            doReturn(mockPipeline).when(blockLocationInfo.getPipeline());
+            doReturn(mockPipeline).when(blockLocationInfo).getPipeline();
             return blockLocationInfo;
           } catch (IOException e) {
             throw new RuntimeException(e);

hadoop-hdds/client/src/test/java/org/apache/hadoop/hdds/scm/storage/TestBlockInputStream.java

@@ -297,18 +297,18 @@ void refreshesPipelineOnReadFailure(IOException ex) throws Exception {
     // GIVEN
     Pipeline pipeline = MockPipeline.createSingleNodePipeline();
     BlockLocationInfo blockLocationInfo = mock(BlockLocationInfo.class);
-    doReturn(pipeline).when(blockLocationInfo.getPipeline());
+    doReturn(pipeline).when(blockLocationInfo).getPipeline();
     Pipeline newPipeline = MockPipeline.createSingleNodePipeline();
     BlockLocationInfo newBlockLocationInfo = mock(BlockLocationInfo.class);
 
     testRefreshesPipelineOnReadFailure(ex, blockLocationInfo,
         id -> newBlockLocationInfo);
 
-    doReturn(newPipeline).when(newBlockLocationInfo.getPipeline());
+    doReturn(newPipeline).when(newBlockLocationInfo).getPipeline();
     testRefreshesPipelineOnReadFailure(ex, blockLocationInfo,
         id -> blockLocationInfo);
 
-    doReturn(null).when(newBlockLocationInfo.getPipeline());
+    doReturn(null).when(newBlockLocationInfo).getPipeline();
     testRefreshesPipelineOnReadFailure(ex, blockLocationInfo,
         id -> newBlockLocationInfo);
   }
@@ -359,7 +359,7 @@ private static ChunkInputStream throwingChunkInputStream(IOException ex,
     if (succeedOnRetry) {
       stubbing.thenReturn(len);
     }
-    doReturn((long) len).when(stream.getRemaining());
+    doReturn((long) len).when(stream).getRemaining();
     return stream;
   }
 
@@ -415,13 +415,13 @@ public void testRefreshOnReadFailureAfterUnbuffer(IOException ex)
     XceiverClientFactory clientFactory = mock(XceiverClientFactory.class);
     XceiverClientSpi client = mock(XceiverClientSpi.class);
     BlockLocationInfo blockLocationInfo = mock(BlockLocationInfo.class);
-    doReturn(client).when(clientFactory.acquireClientForReadData(pipeline));
+    doReturn(client).when(clientFactory).acquireClientForReadData(pipeline);
 
     final int len = 200;
     final ChunkInputStream stream = throwingChunkInputStream(ex, len, true);
 
-    doReturn(blockLocationInfo).when(refreshFunction.apply(blockID));
-    doReturn(newPipeline).when(blockLocationInfo.getPipeline());
+    doReturn(blockLocationInfo).when(refreshFunction).apply(blockID);
+    doReturn(newPipeline).when(blockLocationInfo).getPipeline();
 
     OzoneClientConfig clientConfig = conf.getObject(OzoneClientConfig.class);
     clientConfig.setChecksumVerify(false);

hadoop-hdds/client/src/test/java/org/apache/hadoop/hdds/scm/storage/TestBlockOutputStreamCorrectness.java

@@ -157,7 +157,7 @@ private BlockOutputStream createBlockOutputStream(BufferPool bufferPool)
     final Pipeline pipeline = MockPipeline.createRatisPipeline();
 
     final XceiverClientManager xcm = mock(XceiverClientManager.class);
-    doReturn(new MockXceiverClientSpi(pipeline)).when(xcm.acquireClient(any()));
+    doReturn(new MockXceiverClientSpi(pipeline)).when(xcm).acquireClient(any());
 
     OzoneClientConfig config = new OzoneClientConfig();
     config.setStreamBufferSize(4 * 1024 * 1024);
@@ -185,7 +185,7 @@ private BlockOutputStream createBlockOutputStream(BufferPool bufferPool)
   private ECBlockOutputStream createECBlockOutputStream(OzoneClientConfig clientConfig,
       ECReplicationConfig repConfig, BlockID blockID, Pipeline pipeline) throws IOException {
     final XceiverClientManager xcm = mock(XceiverClientManager.class);
-    doReturn(new MockXceiverClientSpi(pipeline)).when(xcm.acquireClient(any()));
+    doReturn(new MockXceiverClientSpi(pipeline)).when(xcm).acquireClient(any());
 
     ContainerClientMetrics clientMetrics = ContainerClientMetrics.acquire();
     StreamBufferArgs streamBufferArgs =

hadoop-hdds/client/src/test/java/org/apache/hadoop/hdds/scm/storage/TestChunkInputStream.java

@@ -245,16 +245,16 @@ public void connectsToNewPipeline() throws Exception {
     Pipeline newPipeline = MockPipeline.createSingleNodePipeline();
 
     Token<?> token = mock(Token.class);
-    doReturn("oldToken").when(token.encodeToUrlString());
+    doReturn("oldToken").when(token).encodeToUrlString();
     Token<?> newToken = mock(Token.class);
-    doReturn("newToken").when(newToken.encodeToUrlString());
+    doReturn("newToken").when(newToken).encodeToUrlString();
 
     AtomicReference<Pipeline> pipelineRef = new AtomicReference<>(pipeline);
     AtomicReference<Token<?>> tokenRef = new AtomicReference<>(token);
 
     XceiverClientFactory clientFactory = mock(XceiverClientFactory.class);
     XceiverClientSpi client = mock(XceiverClientSpi.class);
-    doReturn(client).when(clientFactory.acquireClientForReadData(any()));
+    doReturn(client).when(clientFactory).acquireClientForReadData(any());
     ArgumentCaptor<ContainerCommandRequestProto> requestCaptor =
         ArgumentCaptor.forClass(ContainerCommandRequestProto.class);
     when(client.getPipeline())

hadoop-hdds/client/src/test/java/org/apache/hadoop/ozone/client/io/TestBlockInputStreamFactoryImpl.java

@@ -60,7 +60,7 @@ public void testNonECGivesBlockInputStream() throws IOException {
         1024 * 1024 * 10);
     Pipeline pipeline = Mockito.spy(blockInfo.getPipeline());
     blockInfo.setPipeline(pipeline);
-    doReturn(1).when(pipeline.getReplicaIndex(any(DatanodeDetails.class)));
+    doReturn(1).when(pipeline).getReplicaIndex(any(DatanodeDetails.class));
     OzoneClientConfig clientConfig = conf.getObject(OzoneClientConfig.class);
     clientConfig.setChecksumVerify(true);
     BlockExtendedInputStream stream =