Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for old signature of IComposableState._on_setattr in 0.19 #399

Open
jchodera opened this issue Jan 27, 2019 · 3 comments
Open
Milestone

Comments

@jchodera
Copy link
Member

YANK tests are emitting the following deprecation warning, which appears to be due to some changes required within openmmtools:

/home/travis/miniconda/envs/test/lib/python3.6/site-packages/openmmtools/states.py:2819: UserWarning: The signature IComposableState._on_setattr(self, standard_system, attribute_name) has been deprecated, and future versions of openmmtools will support only the new one: _on_setattr(self, standard_system, attribute_name, old_composable_state).
  'new one: {}.'.format(old_signature, new_signature))
/home/travis/miniconda/envs/test/lib/python3.6/site-packages/openmmtools/states.py:2819: UserWarning: The signature IComposableState._on_setattr(self, standard_system, attribute_name) has been deprecated, and future versions of openmmtools will support only the new one: _on_setattr(self, standard_system, attribute_name, old_composable_state).
  'new one: {}.'.format(old_signature, new_signature))
/home/travis/miniconda/envs/test/lib/python3.6/site-packages/openmmtools/states.py:2819: UserWarning: The signature IComposableState._on_setattr(self, standard_system, attribute_name) has been deprecated, and future versions of openmmtools will support only the new one: _on_setattr(self, standard_system, attribute_name, old_composable_state).
  'new one: {}.'.format(old_signature, new_signature))
/home/travis/miniconda/envs/test/lib/python3.6/site-packages/openmmtools/states.py:2819: UserWarning: The signature IComposableState._on_setattr(self, standard_system, attribute_name) has been deprecated, and future versions of openmmtools will support only the new one: _on_setattr(self, standard_system, attribute_name, old_composable_state).
  'new one: {}.'.format(old_signature, new_signature))
/home/travis/miniconda/envs/test/lib/python3.6/site-packages/openmmtools/states.py:2819: UserWarning: The signature IComposableState._on_setattr(self, standard_system, attribute_name) has been deprecated, and future versions of openmmtools will support only the new one: _on_setattr(self, standard_system, attribute_name, old_composable_state).
  'new one: {}.'.format(old_signature, new_signature))
@andrrizzi
Copy link
Contributor

This is expected with the latest release. It's something that should be fixed in YANK. I'll edit the title to remind us to remove the deprecation warning and stop supporting the old signature in the next release.

@andrrizzi andrrizzi changed the title Address deprecation warning on IComposableState Drop support for old signature of IComposableState._on_setattr in 0.18 Jan 28, 2019
@jchodera
Copy link
Member Author

@andrrizzi : If this is a YANK issue and not an openmmtools issue, can you open an issue there and close this one?

@andrrizzi
Copy link
Contributor

I've already fixed it there in choderalab/yank#1136. I'm keeping this open with the title changed because it's something we need to remember to do in the next release.

@jchodera jchodera added this to the 0.18.0 milestone Feb 3, 2019
@andrrizzi andrrizzi changed the title Drop support for old signature of IComposableState._on_setattr in 0.18 Drop support for old signature of IComposableState._on_setattr in 0.19 Jul 19, 2019
@andrrizzi andrrizzi modified the milestones: 0.18.0, 0.19 Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants