Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing anthropogenic forcing definition in 245 #40

Open
rguilcas opened this issue Apr 21, 2022 · 4 comments
Open

Missing anthropogenic forcing definition in 245 #40

rguilcas opened this issue Apr 21, 2022 · 4 comments

Comments

@rguilcas
Copy link

In Notebook 245, the anthropogenic part of the forcing is missing in the forcing[scenario] dictionaries.
Probably missing something like the total forcing:

for scenario in scenarios:
forcing[scenario]['total'] = (
forcing[scenario]['co2'] +
forcing[scenario]['ch4'] +
forcing[scenario]['n2o'] +
forcing[scenario]['other_wmghg'] +
forcing[scenario]['o3'] +
forcing[scenario]['h2o_stratospheric'] +
forcing[scenario]['contrails'] +
forcing[scenario]['aerosol-radiation_interactions'] +
forcing[scenario]['aerosol-cloud_interactions'] +
forcing[scenario]['bc_on_snow'] +
forcing[scenario]['land_use'] +
forcing[scenario]['solar'] +
forcing[scenario]['volcanic']
)

@chrisroadmap
Copy link
Owner

Hey, did you solve this in the end or is this still an issue?

@rguilcas
Copy link
Author

rguilcas commented May 4, 2022

Hey! This is still an issue in your notebook. I solved it by adding a similar block to the total forcing without volcanoes and solar forcing:

for scenario in scenarios:
forcing[scenario]['anthro'] = (
forcing[scenario]['co2'] +
forcing[scenario]['ch4'] +
forcing[scenario]['n2o'] +
forcing[scenario]['other_wmghg'] +
forcing[scenario]['o3'] +
forcing[scenario]['h2o_stratospheric'] +
forcing[scenario]['contrails'] +
forcing[scenario]['aerosol-radiation_interactions'] +
forcing[scenario]['aerosol-cloud_interactions'] +
forcing[scenario]['bc_on_snow'] +
forcing[scenario]['land_use']
)

@chrisroadmap
Copy link
Owner

Cool, if you want to make a pull request with the right changes in the notebook I can run it and merge it in if it works

@rguilcas
Copy link
Author

rguilcas commented May 5, 2022

Ok, I will try ! Not so sure how to do it, but tell me if it works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants