Skip to content

Commit 8d6cc37

Browse files
bhamiltoncxCrashpad LUCI CQ
authored and
Crashpad LUCI CQ
committed
[client] Add include-what-you-use pragmas to simulate_crash facade
client/simulate_crash.h is a facade header which shells out to the appropriate platform's header to simulate a crash. Tools like include-what-you-use (IWYU) need a little help understanding this pattern, so they recommend the facade instead of the individual platform headers. This change adds IWYU pragma comments to the headers so the facade header is recommended over an individual platform's header: https://github.com/include-what-you-use/include-what-you-use/blob/master/docs/IWYUPragmas.md Bug: http://b/403338487 Change-Id: I29c82f4e21dc33e959d7cd0dc4dc91209fe7d65e Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/6434621 Commit-Queue: Ben Hamilton <[email protected]> Reviewed-by: Mark Mentovai <[email protected]> Reviewed-by: Justin Cohen <[email protected]>
1 parent fc35662 commit 8d6cc37

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

client/simulate_crash.h

+2
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717

1818
#include "build/build_config.h"
1919

20+
// IWYU pragma: begin_exports
2021
#if BUILDFLAG(IS_MAC)
2122
#include "client/simulate_crash_mac.h"
2223
#elif BUILDFLAG(IS_IOS)
@@ -26,5 +27,6 @@
2627
#elif BUILDFLAG(IS_LINUX) || BUILDFLAG(IS_CHROMEOS) || BUILDFLAG(IS_ANDROID)
2728
#include "client/simulate_crash_linux.h"
2829
#endif
30+
// IWYU pragma: end_exports
2931

3032
#endif // CRASHPAD_CLIENT_SIMULATE_CRASH_H_

0 commit comments

Comments
 (0)