MemoryStream Set: incorrect get size and write to buffer causes exception (C# generator) #71

Author: chronoxor

projects/CSharp/Proto/com.chronoxor.fbe.cs

@@ -1427,7 +1427,7 @@ public override bool Verify()
         }
 
         // Get the bytes value
-        public override void Get(out MemoryStream value) { Get(out value, new MemoryStream(0)); }
+        public override void Get(out MemoryStream value) { Get(out value, new MemoryStream()); }
         public override void Get(out MemoryStream value, MemoryStream defaults)
         {
             Debug.Assert((defaults != null), "Invalid default bytes value!");
@@ -1475,7 +1475,7 @@ public override void Set(MemoryStream value)
 
             Write(FBEOffset, fbeBytesOffset);
             Write(fbeBytesOffset, fbeBytesSize);
-            Write(fbeBytesOffset + 4, value.GetBuffer());
+            Write(fbeBytesOffset + 4, value.GetBuffer(), 0, fbeBytesSize);
         }
     }
 
@@ -6309,7 +6309,7 @@ public override long Verify()
         // Get the bytes value
         public override long Get(out MemoryStream value)
         {
-            value = new MemoryStream(0);
+            value = new MemoryStream();
 
             Debug.Assert(((_buffer.Offset + FBEOffset + 4) <= _buffer.Size), "Model is broken!");
             if ((_buffer.Offset + FBEOffset + 4) > _buffer.Size)
@@ -6342,7 +6342,7 @@ public override long Set(MemoryStream value)
                 return 4;
 
             Write(FBEOffset, fbeBytesSize);
-            Write(FBEOffset + 4, value.GetBuffer());
+            Write(FBEOffset + 4, value.GetBuffer(), 0, fbeBytesSize);
             return 4 + fbeBytesSize;
         }
     }

projects/CSharp/Proto/com.chronoxor.test.cs

@@ -8228,7 +8228,7 @@ public struct StructBytes : IComparable, IComparable<StructBytes>, IEquatable<St
 
         public static StructBytes Default => new StructBytes
         {
-            f1 = new MemoryStream(0)
+            f1 = new MemoryStream()
             , f2 = null
             , f3 = null
         };
@@ -8482,7 +8482,7 @@ public void GetFields(out StructBytes fbeValue, long fbeStructSize)
             if ((fbeCurrentSize + f1.FBESize) <= fbeStructSize)
                 f1.Get(out fbeValue.f1);
             else
-                fbeValue.f1 = new MemoryStream(0);
+                fbeValue.f1 = new MemoryStream();
             fbeCurrentSize += f1.FBESize;
 
             if ((fbeCurrentSize + f2.FBESize) <= fbeStructSize)

source/generator_csharp.cpp

@@ -1031,7 +1031,7 @@ void GeneratorCSharp::GenerateFBEFieldModelBytes()
         }
 
         // Get the bytes value
-        public override void Get(out MemoryStream value) { Get(out value, new MemoryStream(0)); }
+        public override void Get(out MemoryStream value) { Get(out value, new MemoryStream()); }
         public override void Get(out MemoryStream value, MemoryStream defaults)
         {
             Debug.Assert((defaults != null), "Invalid default bytes value!");
@@ -1079,7 +1079,7 @@ void GeneratorCSharp::GenerateFBEFieldModelBytes()
 
             Write(FBEOffset, fbeBytesOffset);
             Write(fbeBytesOffset, fbeBytesSize);
-            Write(fbeBytesOffset + 4, value.GetBuffer());
+            Write(fbeBytesOffset + 4, value.GetBuffer(), 0, fbeBytesSize);
         }
     }
 )CODE";
@@ -2331,7 +2331,7 @@ void GeneratorCSharp::GenerateFBEFinalModelBytes()
         // Get the bytes value
         public override long Get(out MemoryStream value)
         {
-            value = new MemoryStream(0);
+            value = new MemoryStream();
 
             Debug.Assert(((_buffer.Offset + FBEOffset + 4) <= _buffer.Size), "Model is broken!");
             if ((_buffer.Offset + FBEOffset + 4) > _buffer.Size)
@@ -2364,7 +2364,7 @@ void GeneratorCSharp::GenerateFBEFinalModelBytes()
                 return 4;
 
             Write(FBEOffset, fbeBytesSize);
-            Write(FBEOffset + 4, value.GetBuffer());
+            Write(FBEOffset + 4, value.GetBuffer(), 0, fbeBytesSize);
             return 4 + fbeBytesSize;
         }
     }
@@ -8647,7 +8647,7 @@ std::string GeneratorCSharp::ConvertDefault(const std::string& domain, const std
     if (type == "bool")
         return "false";
     else if (type == "bytes")
-        return "new MemoryStream(0)";
+        return "new MemoryStream()";
     else if ((type == "char") || (type == "wchar"))
         return "'\\0'";
     else if ((type == "byte") || (type == "int8") || (type == "uint8") || (type == "int16") || (type == "uint16") || (type == "int32") || (type == "uint32") || (type == "int64") || (type == "uint64"))