diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index c13bfe99..ab4cb04f 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -7,7 +7,6 @@ If you plan to contribute to libjson-rpc-cpp, please skim the following informat The [Makefile](Makefile) contains useful commands that makes development for libjson-rpc-cpp easier. * `make build`: builds the framework in the default configuration -* `make build-docker`: builds the framework for all distributions in docker * `make test`: runs all tests * `make format`: formats all cpp and header files with `clang-format` * `make check-format`: checks if the sources have been formatted @@ -29,7 +28,7 @@ Here are some suggestions: - Adding new connectors. - Adding new languages to the stubgenerator. -Additionally you can find a wishlist and planned features [here](https://github.com/cinemast/libjson-rpc-cpp/projects/1) +In addition, you can find a wishlist and planned features [here](https://github.com/cinemast/libjson-rpc-cpp/projects/1) ### Guidelines / Conventions @@ -43,10 +42,10 @@ Anyway here is a list of how we would prefer your contributions: - Please close issues on yourself if you think a problem has been dealt with. #### Code contributions: - - Please raise a pull-request against the **develop** branch. + - Please raise a pull-request. - If you add features, please keep the test-coverage at 100% line coverage and document them accordingly (doxygen, manpage, etc.). - If you fix a bug, please refer the issue in the [commit message](https://help.github.com/articles/closing-issues-via-commit-messages/). - - Please make sure that the travis-ci build passes (you will get notified if you raise a pull-request). + - Please make sure that the CI build passes (you will get notified if you raise a pull-request). - Add yourself to the AUTHORS.md. - Document your changes in the CHANGELOG.md - Format the code using `make format` diff --git a/README.md b/README.md index b97398ab..09e56a27 100644 --- a/README.md +++ b/README.md @@ -1,7 +1,6 @@ **I created a new C++17 header only implementation -> [json-rpc-cxx](https://github.com/jsonrpcx/json-rpc-cxx).** Master [![CircleCI](https://circleci.com/gh/cinemast/libjson-rpc-cpp/tree/master.svg?style=svg)](https://circleci.com/gh/cinemast/libjson-rpc-cpp/tree/master) -Develop [![CircleCI](https://circleci.com/gh/cinemast/libjson-rpc-cpp/tree/develop.svg?style=svg)](https://circleci.com/gh/cinemast/libjson-rpc-cpp/tree/develop) [![codecov](https://codecov.io/gh/cinemast/libjson-rpc-cpp/branch/master/graph/badge.svg?token=QNoXsaI2ta)](https://codecov.io/gh/cinemast/libjson-rpc-cpp)