Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom plugins #50

Open
c-harding opened this issue Jun 24, 2019 · 3 comments
Open

Custom plugins #50

c-harding opened this issue Jun 24, 2019 · 3 comments

Comments

@c-harding
Copy link
Collaborator

c-harding commented Jun 24, 2019

I'm not sure what to do with other plugins: should we put them in this repo (how should we allow them to be loaded?), or create a new repo/package for each one?

There is also the interesting problem of when to render the elements (see #51), as the current system means that these transformations don't work until first the plugins and then the page are loaded.

@c-harding c-harding changed the title Custom plugins When to render, and custom plugins Jun 24, 2019
@c-harding c-harding changed the title When to render, and custom plugins Custom plugins Jun 24, 2019
@Ryuno-Ki
Copy link

should we put them in this repo

You mean, a monorepo managed with lerna?

Hm, I found lerna not quite intuitive to use, but if they're somewhat deeply coupled (meaning, an update of one part would cause a need for updates in other plugins), then it might be worth it.

What about listing community plugins?
How do they declare compatibility? Via peerDependency?

@c-harding
Copy link
Collaborator Author

I've never used Lerna, I was just wondering whether to put plugins for additional languages (#14) as files within this package, with some sort of dynamic loading, or as separate repos. The plugins certainly won't be coupled with each other, but I'm just concerned that, as each plugin is a small file at best, having each one as a repo is a bit overkill

@scottkellum
Copy link
Collaborator

I was thinking a few core first party plugins in the repo as options to help people get up and running, but allow people to add other plugins on as separate repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants