Skip to content

Commit fe14235

Browse files
review: rename Attribute to InlineAttributes in MarkupXML
1 parent 0639a9e commit fe14235

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

bindings/xml/comment-xml-schema.rng

+1-1
Original file line numberDiff line numberDiff line change
@@ -959,7 +959,7 @@
959959
<param name="pattern">.*\S.*</param>
960960
</data>
961961
</element>
962-
<element name="Attribute">
962+
<element name="InlineAttributes">
963963
<attribute name="attributes"/>
964964
<!-- Non-empty text content. -->
965965
<data type="string">

lib/IDE/CommentConversion.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -73,15 +73,15 @@ struct CommentToXMLConverter {
7373
}
7474

7575
void printInlineAttributes(const InlineAttributes *A) {
76-
OS << "<Attribute attributes=\"";
76+
OS << "<InlineAttributes attributes=\"";
7777
appendWithXMLEscaping(OS, A->getAttributes());
7878
OS << "\">";
7979

8080
for (const auto *N : A->getChildren()) {
8181
printASTNode(N);
8282
}
8383

84-
OS << "</Attribute>";
84+
OS << "</InlineAttributes>";
8585
}
8686

8787
void printBlockQuote(const BlockQuote *BQ) {

test/Inputs/comment_to_something_conversion.swift

+1-1
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ public enum A012_AttachToEntities {
6868
///
6969
/// ^[Attribute text](string: "attributed")
7070
@objc public func f0() {}
71-
// CHECK: {{.*}}DocCommentAsXML=[<Function file="{{.*}}" line="{{.*}}" column="{{.*}}"><Name>f0()</Name><USR>c:@M@comment_to_xml@objc(cs)Attributes(im)f0</USR><Declaration>@objc public func f0()</Declaration><CommentParts><Abstract><Para>Here is an attribute:</Para></Abstract><Discussion><Para><Attribute attributes="string: &quot;attributed&quot;">Attribute text</Attribute></Para></Discussion></CommentParts></Function>]
71+
// CHECK: {{.*}}DocCommentAsXML=[<Function file="{{.*}}" line="{{.*}}" column="{{.*}}"><Name>f0()</Name><USR>c:@M@comment_to_xml@objc(cs)Attributes(im)f0</USR><Declaration>@objc public func f0()</Declaration><CommentParts><Abstract><Para>Here is an attribute:</Para></Abstract><Discussion><Para><InlineAttributes attributes="string: &quot;attributed&quot;">Attribute text</InlineAttributes></Para></Discussion></CommentParts></Function>]
7272
}
7373

7474
@objc public class AutomaticLink {

0 commit comments

Comments
 (0)