[Bug] initDatabase silently ignores a different workspace path on repeat calls

[samzong]

Problem

initDatabase short-circuits on if (db) return;. If it is called a second time with a different workspacePath, the second call is silently ignored and writes continue going to the originally-opened database. A caller that should have used reinitDatabase gets no feedback, and debugging "why are my writes not showing up" becomes very painful.

Location

File: packages/desktop/src/main/db/index.ts:168-171

export function initDatabase(workspacePath: string): void {
  if (db) return;
  openDatabaseAt(workspacePath);
}

Fix Approach

1. Store the workspace path used for the first successful openDatabaseAt call in a module-level variable.
2. On repeat calls, compare the incoming path against the stored one:
   • Same path: return early as today.
   • Different path: throw an explicit error like Error('initDatabase called with different workspace path; use reinitDatabase to switch') — silent-ignore is the bug, so throwing is preferred over warning.

Verification

1. Run pnpm check — must pass.
2. Unit test: call initDatabase('/a'), then initDatabase('/b') — expect a thrown error, not silent ignore.

Context

• WG: Artifact & File System
• Priority: Low
• Estimated effort: 15-20 minutes

[github-actions]

Hi @samzong,
Thanks for opening an issue!
We will look into it as soon as possible.

Details

Instructions for interacting with me using comments are available here.
If you have questions or suggestions related to my behavior, please file an issue against the gh-ci-bot repository.

[snakefood3232]

You're right that initDatabase silently ignoring a different workspacePath on repeat calls is a painful bug to debug. I'd fix this by storing the initial path and throwing a clear error on a mismatch, forcing the caller to use reinitDatabase. I can have a PR with the fix and a unit test up within an hour. I've worked on similar singleton initialization patterns in desktop apps before.