Address PR comments

cli · Feb 7, 2025 · 794568b · 794568b
1 parent 65cf7db
commit 794568b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/pkg/accessibility/accessibility.go b/pkg/accessibility/accessibility.go
@@ -6,7 +6,11 @@ import (
 	"github.com/cli/go-gh/v2/pkg/config"
 )
 
-const ACCESSIBILITY_ENV = "ACCESSIBILITY"
+// ACCESSIBILITY_ENV is the name of the environment variable that can be used to enable
+// accessibility features. If the value is empty, "0", or "false", the accessibility
+// features are disabled. Any other value enables the accessibility features. Note that
+// this environment variable supercedes the configuration file's accessible setting.
+const ACCESSIBILITY_ENV = "GH_ACCESSIBILE"
 
 // IsEnabled returns true if accessibility features are enabled via the ACCESSIBILITY
 // environment variable or the configuration file.

diff --git a/pkg/accessibility/accessibility_test.go b/pkg/accessibility/accessibility_test.go
@@ -34,7 +34,7 @@ func TestIsEnabled(t *testing.T) {
 		},
 		{
 			name:        "When the accessibility configuration is unset and the ACCESSIBLE env var returns 'false', it should return false",
-			envVarValue: "0",
+			envVarValue: "false",
 			cfgStr:      "",
 			wantOut:     false,
 		},
@@ -58,7 +58,7 @@ func TestIsEnabled(t *testing.T) {
 		},
 		{
 			name:        "When the accessibility configuration is set to enabled and the env var is set to '0', it should return false",
-			envVarValue: "false",
+			envVarValue: "0",
 			cfgStr:      accessibilityEnabledConfig(),
 			wantOut:     false,
 		},
@@ -71,7 +71,7 @@ func TestIsEnabled(t *testing.T) {
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			t.Setenv("ACCESSIBILITY", tt.envVarValue)
+			t.Setenv("GH_ACCESSIBILE", tt.envVarValue)
 			testutils.StubConfig(t, tt.cfgStr)
 			assert.Equal(t, tt.wantOut, IsEnabled())
 		})