@iilyak Thanks for writing in. Is the extension that you are working on written in bash? This repo is for the go-gh Go package which can be used by gh extensions written in Go. If you want commands from gh to support these template functions this issue is more suited for the cli/cli repo where this would need to be addressed.

Is the extension that you are working on written in bash? This repo is for the go-gh Go package which can be used by gh extensions written in Go. If you want commands from gh to support these template functions this issue is more suited for the cli/cli repo where this would need to be addressed.

The cli/cli calls out into go-gh to handle template rendering here (template module is imported here). For the context I am trying to do something similar to https://github.com/samcoe/gh-triage/blob/main/gh-triage

    {{- range $index, $label := $issue.labels -}}
      {{- if not $found -}}
        {{- if eq $label.name "p1" "p2" "p3" "core" "help wanted" "tracking issue" "needs-design" "blocked" "needs-user-input" -}}
          {{- $found = true -}}
        {{- end -}}
      {{- end -}}
    {{- end -}}

However in my case all labels in the condition would be prefixed with project:. So it would look like:

    {{- range $index, $label := $issue.labels -}}
      {{- if not $found -}}
        {{- if hasPrefix $label.name "project:" -}}
          {{- $found = true -}}
        {{- end -}}
      {{- end -}}
    {{- end -}}

@iilyak Thank you for the feature request! Agreed that adding some string helpers would be really helpful.

Related: #5976 (reply in thread)

hello,
if you know your prefix and its exact length, would the following fit your use case ?

# posted by iilyak
{{- if hasPrefix $label.name "project:" -}}

# printf
{{- if eq (printf "%.8s" $label.name) "project:" -}}

💁

@iamazeem Thanks for opening a PR for this and being patient while we review and discuss! ❤

I've discussed this with @jtmcg and we want to change the expected output for this. We believe this would be better implemented in go-gh instead of cli/cli so extension authors might benefit from it as well.

We think this might go here: https://github.com/cli/go-gh/blob/13104ed7b2db4b8c1a83de4248ddfaaab7682916/pkg/template/template.go#L36

@iamazeem & anyone else reading: The team has been continuing to discuss this, and we also want this work to limit the functions we import from sprig to the functions requested in this issue:

• contains
• hasPrefix
• hasSuffix
• regexMatch

We think that importing all the functions is a bit more "unknown" surface area than what we are comfortable with.

This filtering would likely be done by calling GenericFuncMap() to get all the functions from sprig then filter it before piping it in to template.FuncMap() from Go's built-in "text/template" package like sprig does in its TxtFuncMap().

@iamazeem & anyone else reading: The team has been continuing to discuss this, and we also want this work to limit the functions we import from sprig to the functions requested in this issue:

• contains
• hasPrefix
• hasSuffix
• regexMatch

We think that importing all the functions is a bit more "unknown" surface area than what we are comfortable with.

This filtering would likely be done by calling GenericFuncMap() to get all the functions from sprig then filter it before piping it in to template.FuncMap() from Go's built-in "text/template" package like sprig does in its TxtFuncMap().

@BagToad: Sounds good to me. 👍
Importing all the functions won't be as straightforward due to the conflict with the existing functions:

Not all of these sprig equivalents exactly map to go-gh so it won't be a drop-in replacement i.e. a breaking change w.r.t. UX.

@BagToad: PR cli/go-gh#184 created. Please review. Thanks!