-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add accessibility package and isEnabled function #180
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Color me impressed with how quick you got this up 😮 Handful of minor things I suspect are quick to knock out.
9ca7222
to
794568b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👨🍳 💋
// accessibility features. If the value is empty, "0", or "false", the accessibility | ||
// features are disabled. Any other value enables the accessibility features. Note that | ||
// this environment variable supercedes the configuration file's accessible setting. | ||
const ACCESSIBILITY_ENV = "ACCESSIBILE" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is spelt incorrectly. "ACCESSIBILE" -> "ACCESSIBLE"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes
stubConfig()
function to utilaccessibility
package andIsEnabled()
functionTesting
This isn't wired up to anything yet, so unless its wired up to its own binary it is just covered by the unit tests. I think this is fine given we're merging into a feature branch right now.