Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add accessibility package and isEnabled function #180

Merged
merged 4 commits into from
Feb 7, 2025

Conversation

jtmcg
Copy link
Contributor

@jtmcg jtmcg commented Feb 7, 2025

Changes

  • Moved duplicated stubConfig() function to util
  • Added accessibility package and IsEnabled() function

Testing

This isn't wired up to anything yet, so unless its wired up to its own binary it is just covered by the unit tests. I think this is fine given we're merging into a feature branch right now.

Copy link
Contributor

@andyfeller andyfeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Color me impressed with how quick you got this up 😮 Handful of minor things I suspect are quick to knock out.

@jtmcg jtmcg force-pushed the jtmcg/accessibility-isEnabled branch from 9ca7222 to 794568b Compare February 7, 2025 16:21
Copy link
Contributor

@andyfeller andyfeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👨‍🍳 💋

@jtmcg jtmcg merged commit a5c6b5e into accessible-colors Feb 7, 2025
8 checks passed
@jtmcg jtmcg deleted the jtmcg/accessibility-isEnabled branch February 7, 2025 18:03
// accessibility features. If the value is empty, "0", or "false", the accessibility
// features are disabled. Any other value enables the accessibility features. Note that
// this environment variable supercedes the configuration file's accessible setting.
const ACCESSIBILITY_ENV = "ACCESSIBILE"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is spelt incorrectly. "ACCESSIBILE" -> "ACCESSIBLE"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants