misc: Apply suggestions from code review

Co-authored-by: Bruno Dias <[email protected]>

Author: nouwaarom

src/registry/github-registry.c

@@ -18,14 +18,16 @@
 #include <curl/curl.h>
 #include <string.h>
 
+#define GITHUB_BASE_URL "https://github.com/"
+
 /**
  * Add `href` to the given `package`.
  */
 static void add_package_href(registry_package_ptr_t self) {
     size_t len = strlen(self->id) + 20; // https://github.com/ \0
     self->href = malloc(len);
     if (self->href)
-        sprintf(self->href, "https://github.com/%s", self->id);
+        sprintf(self->href, GITHUB_BASE_URL "%s", self->id);
 }
 
 /**
@@ -129,4 +131,3 @@ list_t *github_registry_fetch(const char *url) {
     http_get_free(res);
     return list;
 }
-

src/repository/gitlab-repository.c

@@ -10,14 +10,16 @@
 #include <string.h>
 #include <url/url.h>
 
+#define GITLAB_API_V4_URL "https://%s/api/v4%s/repository/files/%s/raw?ref=master"
+
 // GET :hostname/api/v4/projects/:id/repository/files/:file_path/raw
 char* gitlab_repository_get_url_for_file(const char*package_url, const char* slug, const char* version, const char *file, const char* secret) {
   url_data_t *parsed = url_parse(package_url);
 
   int size = strlen(parsed->hostname) + strlen(parsed->pathname) + strlen(file) + 64;
   char *url = malloc(size);
   if (url) {
-    snprintf(url, size, "https://%s/api/v4%s/repository/files/%s/raw?ref=master", parsed->hostname, parsed->pathname, file);
+    snprintf(url, size, GITLAB_API_V4_URL, parsed->hostname, parsed->pathname, file);
   }
 
   url_free(parsed);