Candidate database gets deleted on failed commit.

[pexaxep]

Hello, Olof!

I've encountered the following problem:

I am using private candidate.
I intentionally enter incorrect values in advance to make the commit fail. I make a commit, and my changes that I made (incorrect) are removed from the candidate database, and candidate.X_db and candidate-orig.X_db are deleted.

If I make large changes and accidentally make a mistake somewhere, then after the commit, all changes will be deleted.

@joc-se wrote in #631 that the deletion of candidate.X_db and candidate-orig.X_db should happen after a successful commit.

As I understand, when using private candidate, the commit now includes the update functionality (which implements the deletion of candidate.X_db and candidate-orig.X_db), and it occurs before checking whether the commit was successful. I think the problem is in this.

[joc-se]

Hi,

does incorrect value mean a value that has been changed and committed by another session?

Please describe with an example

Thanks

[pexaxep]

@joc-se

Everything happens within a single session.

1. I log into the CLI.

2. I add configurations (deliberately making a mistake—entering incorrect values according to my YANG model).

3. I perform a commit, which fails with an error.

4. The candidate database is deleted, and there are no changes in the configuration.

When I did the same without a private candidate, after a commit error the configuration changes still remained in the CLI.

[pexaxep]

@olofhagsand

Hi, Olof!

I'm investigating this bug and running into an issue:

• I go into the CLI and load a configuration with an error.
• The commit doesn't go through, but the configuration isn't erased and the database files aren't deleted (OK!).
• Next, I fix the configuration and make a commit, but I get an error again.

Feb 2 21:21:49.163117: clicon_rpc_commit: 1601: Netconf error: Commit failed. Edit and try again or discard changes: application operation-failed Conflict occured: Cannot change node value, node is removed: xpath0: /contexts
CLI command error