KeyError: 'citation'

[Hansyvea]

%cd WARNING DOI for datasets vanuatuvoices is not the latest version!
Traceback (most recent call last):
File "/usr/local/bin/cldfbench", line 8, in
sys.exit(main())
^^^^^^
File "/usr/local/lib/python3.12/dist-packages/cldfbench/main.py", line 89, in main
return args.main(args) or 0
^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/dist-packages/cldfbench/commands/download.py", line 12, in run
with_dataset(args, 'download')
File "/usr/local/lib/python3.12/dist-packages/cldfbench/cli_util.py", line 161, in with_dataset
res = func(*arg, args)
^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/dist-packages/cldfbench/dataset.py", line 162, in _cmd_download
self.cmd_download(args)
File "/content/clics4/lexibank_clics4.py", line 156, in cmd_download
description = meta["citation"]
~~~~^^^^^^^^^^^^
KeyError: 'citation'

[Hansyvea]

This happens when Downloading dataset vanuatuvoices

[xrotwang]

I just created a release of vanuatuvoices which should fix this problem.

[xrotwang]

@LinguList @chrzyki maybe we should somehow freeze CLICS4. The workflow makes some assumptions about individual datasets - such as the presence of a "citation" of the original source - which might not always be met for newer versions of these datasets.

[LinguList]

Freezing sounds good to me. Only upon new releases, it should not be done.

[LinguList]

However, @Hansyvea, why would you anyway follow the download procedure for clics4, if the data are there, so you can dispose of all the information you need now? The download procedure is for initial creation of the data, in the Lexibank/CLDF context, we typically do not employ it, unless we do a new release. So since you probably do not want to release a new version, but rather want to interact with the data, why not use the CLDF dataset as is? We describe in the paper how to convert to Sqlite3, etc.

[LinguList]

I see: we have this under W2 in the README workflow description. I think, @xrotwang, the best way is to make a disclaimer that this applies only to new releases.

[chrzyki]

@LinguList @chrzyki maybe we should somehow freeze CLICS4. The workflow makes some assumptions about individual datasets - such as the presence of a "citation" of the original source - which might not always be met for newer versions of these datasets.

Freezing sounds good and reasonable, yes. Likewise, a disclaimer. The process for building the dataset from scratch should be in there, but a disclaimer explaining that this is not necessary for just working with the CLICS4 data would be good.