Fix clippy

Signed-off-by: Maksym Pavlenko <[email protected]>

Author: mxpv

hv/src/arm64/mod.rs

@@ -15,7 +15,7 @@ pub enum InterruptType {
 
 /// Events that can trigger a guest exit to the VMM.
 #[repr(u32)]
-#[derive(Debug, Copy, Clone, Eq, PartialEq)]
+#[derive(Debug, Default, Copy, Clone, Eq, PartialEq)]
 pub enum ExitReason {
     /// Asynchronous exit requested explicitly by `hv_vcpus_exit` call.
     Canceled = sys::hv_exit_reason_t_HV_EXIT_REASON_CANCELED,
@@ -31,15 +31,10 @@ pub enum ExitReason {
     /// the EOI for the guest's VTimer interrupt handler.
     VTimerActivated = sys::hv_exit_reason_t_HV_EXIT_REASON_VTIMER_ACTIVATED,
     /// Unable to determine exit reason: this should not happen under normal operation.
+    #[default]
     Unknown = sys::hv_exit_reason_t_HV_EXIT_REASON_UNKNOWN,
 }
 
-impl Default for ExitReason {
-    fn default() -> Self {
-        ExitReason::Unknown
-    }
-}
-
 impl From<sys::hv_exit_reason_t> for ExitReason {
     fn from(value: sys::hv_exit_reason_t) -> Self {
         match value {

hv/src/lib.rs

@@ -70,7 +70,7 @@ impl fmt::Display for Error {
             Error::NoResources => write!(f, "The operation was unsuccessful because the host had no resources available to complete the request"),
             Error::NoDevice => write!(f, "The operation was unsuccessful because no VM or vCPU was available"),
             Error::Unsupported => write!(f, "The operation requested isn’t supported by the hypervisor"),
-            Error::Unknown(code) => write!(f, "Error code: {}", *code as i32),
+            Error::Unknown(code) => write!(f, "Error code: {}", *code),
         }
     }
 }

hv/src/vm.rs

@@ -31,10 +31,16 @@ impl Vm {
     /// In order to create child objects (`Vcpu`, `Space`, etc), this object must be wrapped
     /// with [Arc].
     ///
+    #[allow(clippy::not_unsafe_ptr_arg_deref)]
     pub fn new(options: Options) -> Result<Vm, Error> {
         #[cfg(target_arch = "x86_64")]
         let options = options.bits();
 
+        #[cfg(not(target_arch = "x86_64"))]
+        if options.is_null() {
+            return Err(Error::BadArgument);
+        }
+
         call!(sys::hv_vm_create(options))?;
         Ok(Vm)
     }