Skip to content

Commit d5c5709

Browse files
committed
app-auth: check app-version AFTER app-id
Signed-off-by: Alexander Piskun <[email protected]>
1 parent 9d46ecb commit d5c5709

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

nc_py_api/_session.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -365,13 +365,13 @@ def sign_check(self, request: Request) -> None:
365365
if empty_headers:
366366
raise ValueError(f"Missing required headers:{empty_headers}")
367367

368+
if headers["EX-APP-ID"] != self.cfg.app_name:
369+
raise ValueError(f"Invalid EX-APP-ID:{headers['EX-APP-ID']} != {self.cfg.app_name}")
370+
368371
our_version = self.adapter.headers.get("EX-APP-VERSION", "")
369372
if headers["EX-APP-VERSION"] != our_version:
370373
raise ValueError(f"Invalid EX-APP-VERSION:{headers['EX-APP-VERSION']} <=> {our_version}")
371374

372-
if headers["EX-APP-ID"] != self.cfg.app_name:
373-
raise ValueError(f"Invalid EX-APP-ID:{headers['EX-APP-ID']} != {self.cfg.app_name}")
374-
375375
app_secret = get_username_secret_from_headers(headers)[1]
376376
if app_secret != self.cfg.app_secret:
377377
raise ValueError(f"Invalid App secret:{app_secret} != {self.cfg.app_secret}")

0 commit comments

Comments
 (0)