Skip to content

Commit 4199823

Browse files
author
Nikita Dugar
authored
fix labels managedby variables (#3)
1 parent f16e914 commit 4199823

File tree

4 files changed

+25
-17
lines changed

4 files changed

+25
-17
lines changed

README.md

+17-16
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
<hr>
3939

4040

41-
We eat, drink, sleep and most importantly love **DevOps**. We are working towards stratergies for standardizing architecture while ensuring security for the infrastructure. We are strong believer of the philosophy <b>Bigger problems are always solved by breaking them into smaller manageable problems</b>. Resonating with microservices architecture, it is considered best-practice to run database, cluster, storage in smaller <b>connected yet manageable pieces</b> within the infrastructure.
41+
We eat, drink, sleep and most importantly love **DevOps**. We are working towards strategies for standardizing architecture while ensuring security for the infrastructure. We are strong believer of the philosophy <b>Bigger problems are always solved by breaking them into smaller manageable problems</b>. Resonating with microservices architecture, it is considered best-practice to run database, cluster, storage in smaller <b>connected yet manageable pieces</b> within the infrastructure.
4242

4343
This module is basically combination of [Terraform open source](https://www.terraform.io/) and includes automatation tests and examples. It also helps to create and improve your infrastructure with minimalistic code instead of maintaining the whole infrastructure code yourself.
4444

@@ -72,7 +72,7 @@ This module has a few dependencies:
7272
Here is an example of how you can use this module in your inventory structure:
7373
```hcl
7474
module "security_group" {
75-
source = "git::https://github.com/clouddrove/terraform-aws-security-group.git?ref=tags/0.12.3"
75+
source = "git::https://github.com/clouddrove/terraform-aws-security-group.git?ref=tags/0.12.4"
7676
name = "security-group"
7777
application = "clouddrove"
7878
environment = "test"
@@ -93,24 +93,25 @@ Here is an example of how you can use this module in your inventory structure:
9393

9494
| Name | Description | Type | Default | Required |
9595
|------|-------------|:----:|:-----:|:-----:|
96-
| allowed_ip | List of allowed ip. | list | `<list>` | no |
97-
| allowed_ports | List of allowed ingress ports. | list | `<list>` | no |
98-
| application | Application (e.g. `cd` or `clouddrove`). | string | `` | no |
99-
| description | The security group description. | string | `Instance default security group (only egress access is allowed).` | no |
100-
| enable_security_group | Enable default Security Group with only Egress traffic allowed. | bool | `true` | no |
101-
| environment | Environment (e.g. `prod`, `dev`, `staging`). | string | `` | no |
102-
| label_order | Label order, e.g. `name`,`application`. | list | `<list>` | no |
103-
| name | Name (e.g. `app` or `cluster`). | string | `` | no |
104-
| protocol | The protocol. If not icmp, tcp, udp, or all use the. | string | `tcp` | no |
105-
| security_groups | List of Security Group IDs allowed to connect to the instance. | list | `<list>` | no |
106-
| tags | Additional tags (e.g. map(`BusinessUnit`,`XYZ`). | map(string) | `<map>` | no |
107-
| vpc_id | The ID of the VPC that the instance security group belongs to. | string | `` | no |
96+
| allowed\_ip | List of allowed ip. | list | `<list>` | no |
97+
| allowed\_ports | List of allowed ingress ports. | list | `<list>` | no |
98+
| application | Application \(e.g. `cd` or `clouddrove`\). | string | `""` | no |
99+
| description | The security group description. | string | `"Instance default security group (only egress access is allowed)."` | no |
100+
| enable\_security\_group | Enable default Security Group with only Egress traffic allowed. | bool | `"true"` | no |
101+
| environment | Environment \(e.g. `prod`, `dev`, `staging`\). | string | `""` | no |
102+
| label\_order | Label order, e.g. `name`,`application`. | list | `<list>` | no |
103+
| managedby | ManagedBy, eg 'CloudDrove' or 'AnmolNagpal'. | string | `"[email protected]"` | no |
104+
| name | Name \(e.g. `app` or `cluster`\). | string | `""` | no |
105+
| protocol | The protocol. If not icmp, tcp, udp, or all use the. | string | `"tcp"` | no |
106+
| security\_groups | List of Security Group IDs allowed to connect to the instance. | list | `<list>` | no |
107+
| tags | Additional tags \(e.g. map\(`BusinessUnit`,`XYZ`\). | map(string) | `<map>` | no |
108+
| vpc\_id | The ID of the VPC that the instance security group belongs to. | string | `""` | no |
108109

109110
## Outputs
110111

111112
| Name | Description |
112113
|------|-------------|
113-
| security_group_ids | IDs on the AWS Security Groups associated with the instance. |
114+
| security\_group\_ids | IDs on the AWS Security Groups associated with the instance. |
114115
| tags | A mapping of public tags to assign to the resource. |
115116

116117

@@ -144,4 +145,4 @@ At [CloudDrove][website], we offer expert guidance, implementation support and s
144145
[linkedin]: https://cpco.io/linkedin
145146
[twitter]: https://twitter.com/clouddrove/
146147
[email]: https://clouddrove.com/contact-us.html
147-
[terraform_modules]: https://github.com/clouddrove?utf8=%E2%9C%93&q=terraform-&type=&language=
148+
[terraform_modules]: https://github.com/clouddrove?utf8=%E2%9C%93&q=terraform-&type=&language=

README.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ usage : |-
3636
Here is an example of how you can use this module in your inventory structure:
3737
```hcl
3838
module "security_group" {
39-
source = "git::https://github.com/clouddrove/terraform-aws-security-group.git?ref=tags/0.12.3"
39+
source = "git::https://github.com/clouddrove/terraform-aws-security-group.git?ref=tags/0.12.4"
4040
name = "security-group"
4141
application = "clouddrove"
4242
environment = "test"

main.tf

+1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ module "labels" {
1313
name = var.name
1414
application = var.application
1515
environment = var.environment
16+
managedby = var.managedby
1617
label_order = var.label_order
1718
}
1819
locals {

variables.tf

+6
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,12 @@ variable "environment" {
1818
description = "Environment (e.g. `prod`, `dev`, `staging`)."
1919
}
2020

21+
variable "managedby" {
22+
type = string
23+
default = "[email protected]"
24+
description = "ManagedBy, eg 'CloudDrove' or 'AnmolNagpal'."
25+
}
26+
2127
variable "label_order" {
2228
type = list
2329
default = []

0 commit comments

Comments
 (0)