remove unnecessary ts-expect-error definitions

Author: anonrig

src/node/internal/internal_http_client.ts

@@ -168,7 +168,6 @@ export class ClientRequest extends OutgoingMessage implements _ClientRequest {
 
     const signal = options.signal;
     if (signal) {
-      // @ts-expect-error TS2379 Type incompatibility with exactOptionalPropertyTypes
       addAbortSignal(signal, this);
     }
     let method = options.method;

src/node/internal/internal_net.ts

@@ -59,6 +59,11 @@ import {
 import { isUint8Array, isArrayBufferView } from 'node-internal:internal_types';
 import { Duplex } from 'node-internal:streams_duplex';
 import { Buffer } from 'node-internal:internal_buffer';
+import {
+  kDestroyed,
+  kIsReadable,
+  kIsWritable,
+} from 'node-internal:streams_util';
 import type {
   IpcSocketConnectOpts,
   SocketConnectOpts,
@@ -132,13 +137,12 @@ export type SocketOptions = {
   handle?: Socket['_handle'];
   noDelay?: boolean;
   keepAlive?: boolean;
-  allowHalfOpen?: boolean | undefined;
+  allowHalfOpen?: boolean;
   emitClose?: boolean;
-  signal?: AbortSignal | undefined;
+  signal?: AbortSignal;
   onread?:
     | ({ callback?: () => Uint8Array; buffer?: Uint8Array } & OnReadOpts)
-    | null
-    | undefined;
+    | null;
 };
 
 export function Server(): void {
@@ -211,7 +215,14 @@ export declare class Socket extends _Socket {
   _read(n: number): void;
   _reset(): void;
   _getpeername(): Record<string, unknown>;
-  _writableState: null | unknown[];
+  _readableState: undefined;
+  _closed: boolean;
+  writableErrored: boolean;
+  readableErrored: boolean;
+  [kIsReadable]: boolean;
+  [kIsWritable]: boolean;
+  [kDestroyed]: boolean;
+  _writableState: undefined;
   _bytesDispatched: number;
   _pendingData: SocketWriteData | null;
   _pendingEncoding: string;
@@ -331,7 +342,6 @@ export function Socket(this: Socket, options?: SocketOptions): Socket {
   // Call Duplex constructor before setting up the abort signal
   // This ensures the stream methods are properly set up before
   // any abort handling that might call destroy()
-  // @ts-expect-error TS2379 Type incompatibility with exactOptionalPropertyTypes
   Duplex.call(this, options);
 
   if (options.handle) {

src/node/internal/streams_add_abort_signal.ts

@@ -36,10 +36,12 @@ import type { Readable } from 'node-internal:streams_readable';
 import type { Writable } from 'node-internal:streams_writable';
 import type { Transform } from 'node-internal:streams_transform';
 
-export function addAbortSignal(
+type NodeStream = Readable | Writable | Transform;
+
+export function addAbortSignal<T extends { destroy: (err: Error) => void }>(
   signal: unknown,
-  stream: Readable | Writable | Transform
-): Readable | Writable | Transform {
+  stream: T
+): T {
   validateAbortSignal(signal, 'signal');
   if (!isNodeStream(stream)) {
     throw new ERR_INVALID_ARG_TYPE('stream', 'stream.Stream', stream);
@@ -55,7 +57,7 @@ export function addAbortSignal(
     onAbort();
   } else {
     const disposable = addAbortListener(signal, onAbort);
-    eos(stream, disposable[Symbol.dispose]);
+    eos(stream as NodeStream, disposable[Symbol.dispose]);
   }
   return stream;
 }

src/node/internal/streams_state.ts

@@ -31,6 +31,7 @@ let defaultHighWaterMarkObjectMode = 16;
 
 export type HighWaterMarkFromOptions = {
   highWaterMark?: number;
+  [key: string]: number | undefined;
 };
 
 export function highWaterMarkFrom(
@@ -41,8 +42,7 @@ export function highWaterMarkFrom(
   return options.highWaterMark != null
     ? options.highWaterMark
     : isDuplex
-      ? // @ts-expect-error TS7053 Fix this soon.
-        (options[duplexKey] as number)
+      ? (options[duplexKey] as number)
       : null;
 }
 

src/node/internal/streams_util.ts

@@ -493,8 +493,7 @@ export class BufferList {
     if (this.length === 0) return '';
     let p = this.head;
     let ret = '' + p?.data;
-    // @ts-expect-error TS2365 Plus operand warning.
-    while ((p = p?.next ?? null) != null) ret += s + p?.data;
+    while ((p = p?.next ?? null) != null) ret += s + String(p.data);
     return ret;
   }
 

src/node/stream/promises.js

@@ -3,6 +3,5 @@
 //     https://opensource.org/licenses/Apache-2.0
 //
 import { promises } from 'node-internal:streams_promises';
-export {};
 export * from 'node-internal:streams_promises';
 export default promises;