Skip to content

Commit 1ebd8ae

Browse files
committed
use more specific joins for delete request
1 parent 26a9ab0 commit 1ebd8ae

File tree

1 file changed

+14
-9
lines changed

1 file changed

+14
-9
lines changed

app/controllers/v3/service_instances_controller.rb

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -379,15 +379,20 @@ def fetch_writable_service_instance(guid)
379379
def enqueue_delete_job(service_instance)
380380
delete_job = V3::DeleteServiceInstanceJob.new(service_instance.guid, user_audit_info)
381381

382-
service_plan_relations = ServicePlan.eager_graph(service: :service_broker).
383-
where(Sequel[:service_plans][:id] => service_instance.service_plan_id).
384-
all
385-
386-
service_plan = service_plan_relations[0]
387-
388-
plan_name = service_plan.name
389-
service_name = service_plan.service.name
390-
broker_name = service_plan.service.service_broker.name
382+
result = VCAP::CloudController::ServicePlan.
383+
join(:services, id: :service_id).
384+
join(:service_brokers, id: Sequel[:services][:service_broker_id]).
385+
where(Sequel[:service_plans][:id] => service_instance.service_plan_id).
386+
select(
387+
Sequel[:service_plans][:name].as(:plan_name),
388+
Sequel[:services][:label].as(:service_name),
389+
Sequel[:service_brokers][:name].as(:broker_name)
390+
).
391+
first
392+
393+
plan_name = result[:plan_name]
394+
service_name = result[:service_name]
395+
broker_name = result[:broker_name]
391396

392397
logger.info(
393398
"Deleting managed service instance with name '#{service_instance.name}' " \

0 commit comments

Comments
 (0)