File-based-service-bindings: improved errors #4693
Open
+116
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippthun
changed the title
jochenehret
reviewed
Dec 2, 2025
| volume_mounted_files: ServiceBindingFilesBuilder.build(staging_details.package.app) | ||
| }.compact) | ||
| rescue ServiceBindingFilesBuilder::IncompatibleBindings => e | ||
| raise CloudController::Errors::ApiError.new_from_details('UnprocessableEntity', "Cannot build service binding files - #{e.message}") |
Contributor
There was a problem hiding this comment.
Should we use different error messages for these 3 cases? To make the location of the source easier?
Member
Author
There was a problem hiding this comment.
👍 It's now:
- Cannot build service binding files for app
- Cannot build service binding files for app task
- Cannot build service binding files for staging task
The ServiceBindingFilesBuilder can raise an IncompatibleBindings exception in case of entries violating the specification for file names or if the overall file size is too big. When pushing an app these errors were shown as StagerErrors (with the correct error message); for other operations - i.e. restart, restage - an UnknownError was returned. This change ensures that in any case an UnprocessableEntity (ApiError) is returned (with the concrete error message).
Switching from service-binding-k8s to file-based-vcap-services via manifest entries (features) raised an error. This change fixes the wrong validation for this corner case.
philippthun
force-pushed
the
file-based-service-bindings-improved-errors
branch
from
41fbc23 to
00fa649
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IncompatibleBindingserror toUnprocessableEntity(ApiError)I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests