Skip to content

Commit 2e39d01

Browse files
authored
Add support for live parameter in upload presets
1 parent b6f084b commit 2e39d01

File tree

2 files changed

+20
-9
lines changed

2 files changed

+20
-9
lines changed

lib/cloudinary/api.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -212,12 +212,12 @@ def self.delete_upload_preset(name, options={})
212212

213213
def self.update_upload_preset(name, options={})
214214
params = Cloudinary::Uploader.build_upload_params(options)
215-
call_api(:put, "upload_presets/#{name}", params.merge(only(options, :unsigned, :disallow_public_id)), options)
215+
call_api(:put, "upload_presets/#{name}", params.merge(only(options, :unsigned, :disallow_public_id, :live)), options)
216216
end
217217

218218
def self.create_upload_preset(options={})
219219
params = Cloudinary::Uploader.build_upload_params(options)
220-
call_api(:post, "upload_presets", params.merge(only(options, :name, :unsigned, :disallow_public_id)), options)
220+
call_api(:post, "upload_presets", params.merge(only(options, :name, :unsigned, :disallow_public_id, :live)), options)
221221
end
222222

223223
def self.root_folders(options={})

spec/api_spec.rb

Lines changed: 18 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -408,11 +408,15 @@
408408
expected = {:url => /.*\/upload_presets$/,
409409
[:payload, :name] => "new_preset",
410410
[:payload, :folder] => "some_folder",
411-
[:payload, :eval] => EVAL_STR}
411+
[:payload, :eval] => EVAL_STR,
412+
[:payload, :live] => true}
412413
expect(RestClient::Request).to receive(:execute).with(deep_hash_value(expected))
413414

414-
@api.create_upload_preset(:name => "new_preset", :folder => "some_folder", :eval => EVAL_STR,
415-
:tags => [TEST_TAG, TIMESTAMP_TAG])
415+
@api.create_upload_preset(:name => "new_preset",
416+
:folder => "some_folder",
417+
:eval => EVAL_STR,
418+
:tags => [TEST_TAG, TIMESTAMP_TAG],
419+
:live => true)
416420
end
417421

418422
describe "upload_presets" do
@@ -450,13 +454,20 @@
450454
it "should allow updating upload_presets", :upload_preset => true do
451455
name = @api.create_upload_preset(:folder => "folder", :tags => [TEST_TAG, TIMESTAMP_TAG])["name"]
452456
preset = @api.upload_preset(name)
453-
@api.update_upload_preset(name, preset["settings"].merge(:colors => true, :unsigned => true,
454-
:disallow_public_id => true, :eval => EVAL_STR))
457+
@api.update_upload_preset(name, preset["settings"].merge(:colors => true,
458+
:unsigned => true,
459+
:disallow_public_id => true,
460+
:eval => EVAL_STR,
461+
:live => true))
455462
preset = @api.upload_preset(name)
456463
expect(preset["name"]).to eq(name)
457464
expect(preset["unsigned"]).to eq(true)
458-
expect(preset["settings"]).to eq({"folder" => "folder", "colors" => true, "disallow_public_id" => true,
459-
"eval" => EVAL_STR, "tags" => [TEST_TAG, TIMESTAMP_TAG]})
465+
expect(preset["settings"]).to eq("folder" => "folder",
466+
"colors" => true,
467+
"disallow_public_id" => true,
468+
"eval" => EVAL_STR,
469+
"tags" => [TEST_TAG, TIMESTAMP_TAG],
470+
"live" => true)
460471
end
461472

462473
# this test must be last because it deletes (potentially) all dependent transformations which some tests rely on. Excluded by default.

0 commit comments

Comments
 (0)