feat(monitoring): add support for additional labels in PodMonitor configuration #724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:S
racerand
reviewed
Nov 14, 2025
| {{- end }} | ||
| {{- if not (empty .Values.cluster.monitoring.podMonitor.labels) }} | ||
| {{- with .Values.cluster.monitoring.podMonitor.labels }} | ||
| podMonitorAdditionalLabels: |
There was a problem hiding this comment.
This key doesn't exist in the Cluster spec for monitoring. I believe the only way to solve this issue is to externalize the PodMonitor from the Cluster resource.
Author
There was a problem hiding this comment.
Good idea. @racerand please see latest updated code.
dosubot
bot
added
size:M
…figuration Signed-off-by: Nelson Alfonso <[email protected]>
…mplate Signed-off-by: Nelson Alfonso <[email protected]>
…figuration Signed-off-by: Nelson Alfonso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for adding custom labels to the generated
PodMonitorresource in the cluster Helm chart, making it easier to integrate with various monitoring stacks and workflows. Additionally, the logic for PodMonitor and its relabeling configuration has been refactored to improve maintainability, with the relevant configuration now handled in a dedicated template.PodMonitor labels support and configuration refactoring:
labelsfield undercluster.monitoring.podMonitorinvalues.yaml,values.schema.json, and documented it inREADME.md, allowing users to specify additional labels for the PodMonitor resource. [1] [2] [3]labelsfield for PodMonitor, including sample team and environment labels. [1] [2] [3]Refactoring PodMonitor resource generation:
podmonitor.yaml, improving separation of concerns and maintainability.cluster.yaml, centralizing this logic in the new template.cluster.yamlto defer resource creation to the new template, settingenablePodMonitorto false in the main spec.closes: #647