Skip to content

Commit ccccfd1

Browse files
bq validation
1 parent b037661 commit ccccfd1

File tree

2 files changed

+0
-11
lines changed

2 files changed

+0
-11
lines changed

cloudsql-mysql-plugin/src/e2e-test/java/io/cdap/plugin/CloudMySqlClient.java

-8
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
import io.cdap.e2e.utils.PluginPropertyUtils;
44
import org.junit.Assert;
5-
65
import java.sql.*;
76
import java.util.Date;
87
import java.util.GregorianCalendar;
@@ -108,8 +107,6 @@ public static void createSourceTable(String sourceTable) throws SQLException, Cl
108107
statement.executeUpdate("INSERT INTO " + sourceTable + " (id, lastName)" + "VALUES (1, 'Priya')");
109108
statement.executeUpdate("INSERT INTO " + sourceTable + " (id, lastName)" + "VALUES (2, 'Shubhangi')");
110109
statement.executeUpdate("INSERT INTO " + sourceTable + " (id, lastName)" + "VALUES (3, 'Shorya')");
111-
112-
113110
}
114111
}
115112

@@ -128,8 +125,6 @@ public static void createSourceDatatypesTable(String sourceTable) throws SQLExce
128125
String datatypesColumns = PluginPropertyUtils.pluginProp("datatypesColumns");
129126
String createSourceTableQuery = "CREATE TABLE " + sourceTable + " " + datatypesColumns;
130127
statement.executeUpdate(createSourceTableQuery);
131-
System.out.println(createSourceTableQuery);
132-
133128
// Insert dummy data.
134129
String datatypesValues = PluginPropertyUtils.pluginProp("datatypesValue1");
135130
String datatypesColumnsList = PluginPropertyUtils.pluginProp("datatypesColumnsList");
@@ -142,7 +137,6 @@ public static void createTargetDatatypesTable(String targetTable) throws SQLExce
142137
String datatypesColumns = PluginPropertyUtils.pluginProp("datatypesColumns");
143138
String createTargetTableQuery = "CREATE TABLE " + targetTable + " " + datatypesColumns;
144139
statement.executeUpdate(createTargetTableQuery);
145-
System.out.println(createTargetTableQuery);
146140
}
147141
}
148142

@@ -151,11 +145,9 @@ public static void createTargetCloudMysqlTable(String targetTable) throws SQLExc
151145
String datatypesColumns = PluginPropertyUtils.pluginProp("CloudMySqlDatatypesColumns");
152146
String createTargetTableQuery = "CREATE TABLE " + targetTable + " " + datatypesColumns;
153147
statement.executeUpdate(createTargetTableQuery);
154-
System.out.println(createTargetTableQuery);
155148
}
156149
}
157150

158-
159151
public static void dropTables(String[] tables) throws SQLException, ClassNotFoundException {
160152
try (Connection connect = getCloudSqlConnection(); Statement statement = connect.createStatement()) {
161153
for (String table : tables) {

cloudsql-mysql-plugin/src/e2e-test/java/io/cdap/plugin/common/stepsdesign/TestSetupHooks.java

-3
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,6 @@ public static void setTableName() {
3131
PluginPropertyUtils.addPluginProp("sourceTable", sourceTableName);
3232
PluginPropertyUtils.addPluginProp("targetTable", targetTableName);
3333
PluginPropertyUtils.addPluginProp("selectQuery", String.format("select * from %s", sourceTableName));
34-
System.out.println(sourceTableName);
35-
3634
}
3735

3836
@Before(order = 1)
@@ -147,7 +145,6 @@ private static void createSourceBQTableWithQueries(String bqCreateTableQueryFile
147145
// Insert query does not return any record.
148146
// Iterator on TableResult values in getSoleQueryResult method throws NoSuchElementException
149147
}
150-
System.out.println(bqSourceTable);
151148
PluginPropertyUtils.addPluginProp("bqSourceTable", bqSourceTable);
152149
BeforeActions.scenario.write("BQ Source Table " + bqSourceTable + " created successfully");
153150
}

0 commit comments

Comments
 (0)