Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some specialized class instances are not inlined properly. #1390

Open
YarinHeffes opened this issue Feb 13, 2025 · 0 comments
Open

Some specialized class instances are not inlined properly. #1390

YarinHeffes opened this issue Feb 13, 2025 · 0 comments

Comments

@YarinHeffes
Copy link
Collaborator

As far as I can tell, the specialized methods == and + are implemented according to the same pattern for complex floats. However only the specialized == is inlined as expected.

COALTON-USER> (coalton-toplevel
                (define x (lisp (Complex Double-Float) () #C(1.0d0 2.0d0)))
                (define y (lisp (Complex Double-Float) () #C(3.0d0 3.0d0))))
; No value
COALTON-USER> (coalton-codegen-types
                (monomorphize) (define z (+ x y))
                (monomorphize) (define p (== x y)))
(COMMON-LISP:PROGN
 (COMMON-LISP:DECLAIM
  (SB-EXT:MUFFLE-CONDITIONS SB-KERNEL:REDEFINITION-WARNING))
 (COALTON-IMPL/GLOBAL-LEXICAL:DEFINE-GLOBAL-LEXICAL P COMMON-LISP:BOOLEAN)
 (COMMON-LISP:SETF P
                     (COMMON-LISP:LET ((#:B-11129489 Y))
                       (COMMON-LISP:DECLARE
                        (COMMON-LISP:IGNORABLE #:B-11129489))
                       (COMMON-LISP:LET ((#:A-11119488 X))
                         (COMMON-LISP:DECLARE
                          (COMMON-LISP:IGNORABLE #:A-11119488))
                         (COMMON-LISP:LET ((#:A-11529493 #:A-11119488))
                           (COMMON-LISP:DECLARE
                            (COMMON-LISP:IGNORABLE #:A-11529493))
                           (COMMON-LISP:LET ((#:B-11539494 #:B-11129489))
                             (COMMON-LISP:DECLARE
                              (COMMON-LISP:IGNORABLE #:B-11539494))
                             (COMMON-LISP:THE
                              (COMMON-LISP:VALUES COMMON-LISP:BOOLEAN
                                                  COMMON-LISP:&OPTIONAL)
                              (COMMON-LISP:LET ((COALTON-LIBRARY/MATH/COMPLEX::B
                                                 #:B-11539494)
                                                (COALTON-LIBRARY/MATH/COMPLEX::A
                                                 #:A-11529493))
                                (COMMON-LISP:DECLARE
                                 (COMMON-LISP:TYPE
                                  (COMMON-LISP:COMPLEX
                                   COMMON-LISP:DOUBLE-FLOAT)
                                  COALTON-LIBRARY/MATH/COMPLEX::A
                                  COALTON-LIBRARY/MATH/COMPLEX::B))
                                (COMMON-LISP:VALUES
                                 (COMMON-LISP:= COALTON-LIBRARY/MATH/COMPLEX::A
                                                COALTON-LIBRARY/MATH/COMPLEX::B)))))))))
 (COMMON-LISP:SETF (COMMON-LISP:DOCUMENTATION 'P 'COMMON-LISP:VARIABLE)
                     "P :: BOOLEAN")
 (COALTON-IMPL/GLOBAL-LEXICAL:DEFINE-GLOBAL-LEXICAL Z
                                                    (COMMON-LISP:COMPLEX
                                                     COMMON-LISP:DOUBLE-FLOAT))
 (COMMON-LISP:SETF Z
                     (COMMON-LISP:LET ((#:B-11149492 Y))
                       (COMMON-LISP:DECLARE
                        (COMMON-LISP:IGNORABLE #:B-11149492))
                       (COMMON-LISP:LET ((#:A-11139491 X))
                         (COMMON-LISP:DECLARE
                          (COMMON-LISP:IGNORABLE #:A-11139491))
                         (COALTON-LIBRARY/MATH/COMPLEX::COMPLEX-PLUS
                          COALTON-LIBRARY/MATH/COMPLEX::|INSTANCE/COMPLEX DOUBLE-FLOAT|
                          #:A-11139491 #:B-11149492))))
 (COMMON-LISP:SETF (COMMON-LISP:DOCUMENTATION 'Z 'COMMON-LISP:VARIABLE)
                     "Z :: (COMPLEX DOUBLE-FLOAT)")
 (COMMON-LISP:DECLAIM
  (SB-EXT:UNMUFFLE-CONDITIONS SB-KERNEL:REDEFINITION-WARNING))
 (COMMON-LISP:VALUES))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants