kvserver: skip flaky TestReplicateQueueRebalanceMultiStore #158358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates cockroachdb#156293. Release note: none. Epic: none.
Member
|
This change is |
miraradeva
approved these changes
Nov 25, 2025
Contributor
miraradeva
left a comment
miraradeva
left a comment
There was a problem hiding this comment.
LGTM but pinging @pav-kv to confirm since he spent a bunch of time trying to understand what's going on with this test.
Contributor
Author
|
Would it work to skip on master for now and utilize more isolated PR branches to exercise the unskipped path for deeper debugging until it is stabilized? |
Member
|
Or skip during CI, but not nightlies, if we have a facility for that. |
pav-kv
reviewed
Nov 26, 2025
| storesPerNode int | ||
| }{ | ||
| {"simple", 5, 1}, | ||
| {"multi-store", 4, 2}, |
Collaborator
There was a problem hiding this comment.
Only this multi-store variant flakes. Can we skip just that?
As an extension of that, can we skip just in line 369 in case the query times out?
Collaborator
There was a problem hiding this comment.
@dt but let's merge, and we in KV can iterate on this async.
pav-kv
approved these changes
Nov 26, 2025
Member
|
bors r+ |
Contributor
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #156293.
Release note: none.
Epic: none.