Fix json parse with author is null when fetching pull requests info

Author: machadoit

src/main/scala/com/codacy/client/bitbucket/PullRequest.scala

@@ -5,7 +5,7 @@ import play.api.libs.functional.syntax._
 import play.api.libs.json._
 
 case class PullRequest(id: Long, title: String, description: String,
-                       authorUsername: String, authorAvatar: Option[String],
+                       authorUsername: Option[String], authorAvatar: Option[String],
                        state: String, created_on: DateTime, updated_on: DateTime,
                        sourceRepository: String, sourceBranch: String, sourceCommit: String,
                        destRepository: String, destBranch: String, destCommit: Option[String],
@@ -47,8 +47,8 @@ object PullRequest {
     (__ \ "id").read[Long] and
       (__ \ "title").read[String] and
       (__ \ "description").read[String] and
-      (__ \ "author" \ "username").read[String] and
-      (__ \ "author" \ "links" \ "avatar" \ "href").read[Option[String]] and
+      (__ \ "author" \ "username").readNullable[String] and
+      (__ \ "author" \ "links" \ "avatar" \ "href").readNullable[String].orElse((__ \ "author" \ "links").readNullable[String]) and
       (__ \ "state").read[String] and
       (__ \ "created_on").read[DateTime] and
       (__ \ "updated_on").read[DateTime] and

src/test/scala/RemoteRepositorySpecs.scala

@@ -265,4 +265,126 @@ class RemoteRepositorySpecs extends FlatSpec with Matchers {
 
     parsed shouldBe true
   }
+
+  it should "successfully parse a JSON with null author while getting info for PRs" in {
+
+    val input =
+      """
+        |{
+        |  "description": "",
+        |  "links": {
+        |    "decline": {
+        |      "href": "https://bitbucket.org/wtv"
+        |    },
+        |    "commits": {
+        |      "href": "https://bitbucket.org/wtv"
+        |    },
+        |    "self": {
+        |      "href": "https://bitbucket.org/wtv"
+        |    },
+        |    "comments": {
+        |      "href": "https://bitbucket.org/wtv"
+        |    },
+        |    "merge": {
+        |      "href": "https://bitbucket.org/wtv"
+        |    },
+        |    "html": {
+        |      "href": "https://bitbucket.org/wtv"
+        |    },
+        |    "activity": {
+        |      "href": "https://bitbucket.org/wtv"
+        |    },
+        |    "diff": {
+        |      "href": "https://bitbucket.org/wtv"
+        |    },
+        |    "approve": {
+        |      "href": "https://bitbucket.org/wtv"
+        |    },
+        |    "statuses": {
+        |      "href": "https://bitbucket.org/wtv"
+        |    }
+        |  },
+        |  "title": "Potatos",
+        |  "close_source_branch": true,
+        |  "merge_commit": null,
+        |  "destination": {
+        |    "commit": {
+        |      "hash": "aaaaaaaaaaaa",
+        |      "links": {
+        |        "self": {
+        |          "href": "https://bitbucket.org/wtv"
+        |        }
+        |      }
+        |    },
+        |    "repository": {
+        |      "links": {
+        |        "self": {
+        |          "href": "https://bitbucket.org/wtv"
+        |        },
+        |        "html": {
+        |          "href": "https://bitbucket.org/wtv"
+        |        },
+        |        "avatar": {
+        |          "href": "https://bitbucket.org/wtv"
+        |        }
+        |      },
+        |      "type": "repository",
+        |      "name": "my-potatos",
+        |      "full_name": "codacy/my-potatos",
+        |      "uuid": "{70bb8ec5-0c14-4964-aaaa-ebb4b2235ecf}"
+        |    },
+        |    "branch": {
+        |      "name": "master"
+        |    }
+        |  },
+        |  "state": "OPEN",
+        |  "closed_by": null,
+        |  "source": {
+        |    "commit": {
+        |      "hash": "bbbbbbbbbbbb",
+        |      "links": {
+        |        "self": {
+        |          "href": "https://bitbucket.org/wtv"
+        |        }
+        |      }
+        |    },
+        |    "repository": {
+        |      "links": {
+        |        "self": {
+        |          "href": "https://bitbucket.org/wtv"
+        |        },
+        |        "html": {
+        |          "href": "https://bitbucket.org/wtv"
+        |        },
+        |        "avatar": {
+        |          "href": "https://bitbucket.org/wtv"
+        |        }
+        |      },
+        |      "type": "repository",
+        |      "name": "my-potatos",
+        |      "full_name": "codacy/my-potatos",
+        |      "uuid": "{c08af10a-b49f-4a7a-9edb-6a66b3495a6f}"
+        |    },
+        |    "branch": {
+        |      "name": "add-more-potatos"
+        |    }
+        |  },
+        |  "comment_count": 0,
+        |  "author": null,
+        |  "created_on": "2016-04-05T14:35:41.678131+00:00",
+        |  "reason": "",
+        |  "updated_on": "2016-11-01T14:25:45.932586+00:00",
+        |  "type": "pullrequest",
+        |  "id": 333,
+        |  "task_count": 0
+        |}
+      """.stripMargin
+    val json = Json.parse(input)
+    val value = json.validate[PullRequest]
+
+    val parsed = value.fold(e => false, r => r.destCommit.isDefined)
+
+    parsed shouldBe true
+
+  }
 }