fix webpack (#4856)

* fix webpack

* fix jsx configuration

Author: DMarinhoCodacy

.gitignore

@@ -7,4 +7,7 @@ tsconfig.tsbuildinfo
 .vscode
 .codarcyrc
 /tests
-.eslintcache
+.eslintcache
+
+#Ignore vscode AI rules
+.github/copilot-instructions.md

docs/multiple-tests/security-node/src/.eslintrc.json

@@ -4,8 +4,5 @@
   ],
   "extends": [
     "plugin:security-node/recommended"
-  ],
-  "rules": {
-    "security-node/non-literal-reg-expr": "warn"
-  }
+  ]
 }

package-lock.json

@@ -74,14 +74,11 @@
     "@angular/compiler": "^17.3.9",
     "@babel/cli": "^7.24.8",
     "@babel/core": "^7.24.5",
-    "@babel/eslint-parser": "^7.25.1",
     "@babel/eslint-plugin": "^7.24.5",
     "@babel/plugin-proposal-throw-expressions": "^7.24.7",
     "@babel/plugin-transform-object-assign": "^7.24.7",
     "@babel/plugin-transform-object-rest-spread": "^7.24.5",
     "@babel/plugin-transform-runtime": "^7.24.3",
-    "@babel/preset-env": "^7.24.5",
-    "@babel/preset-react": "^7.24.1",
     "@babel/register": "^7.23.7",
     "@babel/runtime": "^7.25.0",
     "@cityelectricalfactors/eslint-config-base": "^1.0.3",
@@ -390,6 +387,9 @@
     "yup": "^1.4.0"
   },
   "devDependencies": {
+    "@babel/eslint-parser": "^7.28.0",
+    "@babel/preset-env": "^7.28.0",
+    "@babel/preset-react": "^7.27.1",
     "@trivago/prettier-plugin-sort-imports": "^5.2.2"
   }
 }

package.json

@@ -39,15 +39,13 @@ function generateFilesToAnalyze(codacyrc: Codacyrc): string[] {
     ? codacyrc.files
     : defaultFilesToAnalyze;
 
-  // Files to exclude
   const excludedFiles = [
     "package.json",
     "package-lock.json",
     "yarn.lock",
     "pnpm-lock.yaml"
   ];
 
-  // Filter out excluded files
   const filteredFiles = files.filter(
     file => !excludedFiles.some(excluded => file.endsWith(excluded))
   );
@@ -81,30 +79,25 @@ async function generateEslintOptions (
 
   const options: ESLint.Options = Object.assign({}, baseOptions, cloneDeep(defaultOptions))
 
+  // Initialize baseConfig if it doesn't exist
+  if (!options.baseConfig) {
+    options.baseConfig = {}
+  }
+
   if (DEBUG && useRepoPatterns && !existsEslintConfig) {
     const patternsSet = "recommended"
     patterns = await retrieveCodacyPatterns(patternsSet)
     options.baseConfig.rules = convertPatternsToEslintRules(patterns)
     debug(`options: setting ${patternsSet} (${patterns.length}) patterns`)
   } else if (useCodacyPatterns) {
-    //TODO: move this logic to a generic (or specific) plugin function
-
-    // There are some plugins that their rules should only apply for
-    // some specific file types / files names. So when those are enabled
-    // explicitly we need to apply them with a bit of customization.
-    //
-    //   example: a rule for the storybook should only apply to files with
-    //            "story" or "stories" in the name. If enabled for all files it
-    //            reports false positives on normal files.
-    //            check: conf file @ eslint-plugin-storybook/configs/recommended.js
-
     const [storybookPatterns, otherPatterns] = partition(patterns, (p: Pattern) =>
       p.patternId.startsWith("storybook")
     )
 
-    // configure override in case storybook plugin rules being turned on
     if (storybookPatterns.length) {
       debug(`options: setting ${storybookPatterns.length} storybook patterns`)
+      // Ensure overrides is initialized
+      options.baseConfig.overrides ||= []
       options.baseConfig.overrides.push({
         "files": [
           "*.stories.@(ts|tsx|js|jsx|mjs|cjs)",
@@ -114,25 +107,26 @@ async function generateEslintOptions (
       })
     }
 
-    // explicitly use only the rules being passed by codacyrc
     if (otherPatterns.length) {
       debug(`options: setting ${otherPatterns.length} patterns`)
       options.baseConfig.rules = convertPatternsToEslintRules(otherPatterns)
     }
   }
+  // Ensure plugins is initialized
+  options.baseConfig.plugins ||= []
 
   // load only the plugins that are being used in loaded rules
   const prefixes = getPatternsUniquePrefixes(patterns)
-  prefixes
-    .filter((prefix) => prefix !== "")
-    .forEach(async (prefix) => {
-      (await getPluginsName()).includes(prefix)
-        ? options.baseConfig.plugins.push(prefix)
-        : debug(`options: plugin ${prefix} not found`)
-    })
 
-  debug("options: finished")
+  for (const prefix of prefixes.filter((p) => p !== "")) {
+    if ((await getPluginsName()).includes(prefix)) {
+      options.baseConfig.plugins.push(prefix)
+    } else {
+      debug(`options: plugin ${prefix} not found`)
+    }
+  }
 
+  debug("options: finished")
   return options
 }
 
@@ -192,7 +186,6 @@ async function retrieveCodacyPatterns (set: "recommended" | "all" = "recommended
     .filter(([patternId, rule]) =>
       !isBlacklisted(patternId)
       && !(rule?.meta?.deprecated && rule.meta.deprecated === true)
-      // problems with the path generated (win vs nix) for this specific pattern
       && (!DEBUG || patternId != "spellcheck_spell-checker")
       && (set !== "recommended" || DocGenerator.isDefaultPattern(patternIdToEslint(patternId), rule.meta))
     )
@@ -212,4 +205,4 @@ async function retrieveCodacyPatterns (set: "recommended" | "all" = "recommended
 
   debug(`options: returning ${set} (${patterns.length}) patterns`)
   return patterns
-}
+}

src/configCreator.ts

@@ -121,8 +121,7 @@ export const defaultOptions: ESLint.Options = {
         },
         "typescript": {
           "alwaysTryTypes": true
-        },
-        "webpack": true
+      }
       },
       "jest": {
         "version": 29
@@ -218,20 +217,21 @@ export const defaultOptions: ESLint.Options = {
         "rules": {
           "json/json": "off"
         }
-      }
+      },
       // JSX with Babel
-      // https://www.npmjs.com/package/@babel/eslint-parser
-      // "When should I use @babel/eslint-parser?"
-      // {
-      //   "files": ["**/*.jsx"],
-      //   "parser": "@babel/eslint-parser",
-      //   "parserOptions": {
-      //     "babelOptions": {
-      //       "presets": ["@babel/preset-env"]
-      //     },
-      //     "requireConfigFile": false
-      //   }
-      // }
+      {
+        "files": ["**/*.jsx"],
+        "parser": "@babel/eslint-parser",
+        "parserOptions": {
+          "babelOptions": {
+            "presets": [
+              "@babel/preset-env",
+              "@babel/preset-react"
+            ]
+          },
+          "requireConfigFile": false
+        }
+      }
     ]
   }
 }

src/eslintDefaultOptions.ts

@@ -19,4 +19,4 @@
     "src/**/*.ts",
     "package.json"
   ]
-}
+}