Skip to content

Conversation

@josemarluedke
Copy link
Contributor

@josemarluedke josemarluedke commented Aug 5, 2019

Fixes #53.

@lindyhopchris
Copy link
Contributor

Thanks for this! Looks good.

The only thing that occurs to me is do we know what happens if load is called a second time with a different key? Just wondering what happens as that might be the implication of the original post in #39

@josemarluedke
Copy link
Contributor Author

That's a good question. I don't know the consequences of that. However, we do prevent calling configure if it was already configured, so I guess that's safe.

I guess this PR does not fix #39.

@lindyhopchris
Copy link
Contributor

Yeah, need to clarify whether toggling the publishable key is a requirement and/or even possible. But this PR is great at the mo so will merge for now.

@lindyhopchris lindyhopchris merged commit aab8c7b into code-corps:develop Aug 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lazy initialize stripe configuration

2 participants