Merge pull request #7 from code-yeongyu/improve-readability-constructor

생성자의 인자에서 바로 프로퍼티를 정의하도록 변경합니다.

Author: code-yeongyu

src/app/naver/elementParser.ts

@@ -2,7 +2,6 @@ import puppeteer from "puppeteer";
 import { PaymentHistory } from "../common";
 
 export default class ElementParser {
-  private readonly page: puppeteer.Page;
   private static async parseName(element: puppeteer.ElementHandle) {
     const name =
       (await element.$eval(
@@ -12,7 +11,7 @@ export default class ElementParser {
     return name;
   }
 
-  constructor(page: puppeteer.Page) {
+  constructor(private readonly page: puppeteer.Page) {
     this.page = page;
   }
 

src/app/naver/pageInteractor.ts

@@ -8,11 +8,12 @@ export type LoginEvent =
   | "unexpected";
 
 export default class PageInteractor {
-  private readonly page: puppeteer.Page;
-  private readonly elementParser: ElementParser;
   private _fullyLoaded = false;
 
-  constructor(page: puppeteer.Page, elementParser: ElementParser) {
+  constructor(
+    private readonly page: puppeteer.Page,
+    private readonly elementParser: ElementParser
+  ) {
     this.page = page;
     this.elementParser = elementParser;
   }

src/app/naver/service.ts

@@ -10,9 +10,7 @@ import {
 import { Module } from ".";
 
 export default class Service {
-  private readonly module: Module;
-
-  constructor(module: Module) {
+  constructor(private readonly module: Module) {
     this.module = module;
   }
 

src/app/naver/urlChanger.ts

@@ -1,12 +1,11 @@
 import puppeteer from "puppeteer";
 
 export default class URLChanger {
-  private readonly page: puppeteer.Page;
   loginURL = "https://nid.naver.com/nidlogin.login";
   paymentHistoryURL =
     "https://new-m.pay.naver.com/historybenefit/paymenthistory";
 
-  constructor(page: puppeteer.Page) {
+  constructor(private readonly page: puppeteer.Page) {
     this.page = page;
   }