Lazily evaluate dockerRun configuration

Authored-by: Leonhardt Koepsell <[email protected]>

Author: lnhrdt

CHANGELOG.md

@@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Fixed
 
 - Simplify the path evaluation for docker
+- Lazily evaluate dockerRun configuration
 
 ## [0.1.0] - 2024-11-07
 

src/main/kotlin/dev/codebandits/container/gradle/tasks/ContainerRunTask.kt

@@ -18,34 +18,34 @@ public abstract class ContainerRunTask : ContainerExecTask() {
   }
 
   public fun dockerRun(configure: DockerRunSpec.() -> Unit) {
-    val spec = DockerRunSpec(project.objects).apply(configure)
-    val image = spec.image.get()
-    val options = mutableListOf<String>()
-    val user = spec.user.orNull
-    if (user != null) {
-      options.addAll(listOf("--user", user))
-    }
-    if (spec.privileged.get()) {
-      options.add("--privileged")
-    }
-    if (spec.autoRemove.get()) {
-      options.add("--rm")
-    }
-    spec.volumes.get().forEach { volume ->
-      options.addAll(listOf("--volume", volume))
-    }
-    val entrypoint = spec.entrypoint.orNull
-    if (entrypoint != null) {
-      options.addAll(listOf("--entrypoint", entrypoint))
-    }
-    val workdir = spec.workdir.orNull
-    if (workdir != null) {
-      options.addAll(listOf("--workdir", workdir))
-    }
-    val dockerArgs = arrayOf("run", *options.toTypedArray(), image, *spec.args.get())
     actionSteps.add(
       ExecutionStep(
         execAction = {
+          val spec = DockerRunSpec(project.objects).apply(configure)
+          val image = spec.image.get()
+          val options = mutableListOf<String>()
+          val user = spec.user.orNull
+          if (user != null) {
+            options.addAll(listOf("--user", user))
+          }
+          if (spec.privileged.get()) {
+            options.add("--privileged")
+          }
+          if (spec.autoRemove.get()) {
+            options.add("--rm")
+          }
+          spec.volumes.get().forEach { volume ->
+            options.addAll(listOf("--volume", volume))
+          }
+          val entrypoint = spec.entrypoint.orNull
+          if (entrypoint != null) {
+            options.addAll(listOf("--entrypoint", entrypoint))
+          }
+          val workdir = spec.workdir.orNull
+          if (workdir != null) {
+            options.addAll(listOf("--workdir", workdir))
+          }
+          val dockerArgs = arrayOf("run", *options.toTypedArray(), image, *spec.args.get())
           executable = "docker"
           args(*dockerArgs)
           val dockerHost = spec.dockerHost.orNull

src/testFeatures/kotlin/dev/codebandits/container/gradle/DockerRunDeferredConfigurationEvaluationTest.kt

@@ -0,0 +1,42 @@
+package dev.codebandits.container.gradle
+
+import dev.codebandits.container.gradle.helpers.appendLine
+import org.gradle.testkit.runner.GradleRunner
+import org.gradle.testkit.runner.TaskOutcome
+import org.junit.jupiter.api.Test
+import strikt.api.expectThat
+import strikt.assertions.isEqualTo
+import strikt.assertions.isNotNull
+
+class DockerRunDeferredConfigurationEvaluationTest : GradleProjectTest() {
+
+  @Test
+  fun `dockerRun configuration evaluation is deferred`() {
+    buildGradleKtsFile.appendLine(
+      """
+      import dev.codebandits.container.gradle.tasks.ContainerRunTask
+      
+      plugins {
+        id("dev.codebandits.container")
+      }
+      
+      tasks {
+        register<ContainerRunTask>("notReady") {
+          val imageProvider = project.provider<String> { TODO() }
+          dockerRun {
+            image = imageProvider.get()
+          }
+        }
+      }
+      """.trimIndent()
+    )
+
+    val result = GradleRunner.create()
+      .withPluginClasspath()
+      .withProjectDir(projectDirectory.toFile())
+      .withArguments("tasks")
+      .build()
+
+    expectThat(result).get { task(":tasks") }.isNotNull().get { outcome }.isEqualTo(TaskOutcome.SUCCESS)
+  }
+}