Skip to content

Commit b8a414b

Browse files
authored
V9.1.2/compatibility fixes (#28)
⏪ fixed unwanted breaking change by re-introducing virtual ⬆️ updated testrunner for docker 🔧 consistency for private assets (although scoped for tests only) 💬 updated community health pages 📦 updated NuGet package definition ⚗️ asked copilot for help as DisposableTest.UnmanagedDisposable_VerifyThatAssetIsBeingDisposedOnFinalize ONLY fails in GHA/W2022
1 parent 52e412b commit b8a414b

File tree

9 files changed

+47
-9
lines changed

9 files changed

+47
-9
lines changed

.nuget/Codebelt.Extensions.Xunit.App/PackageReleaseNotes.txt

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,10 @@
1-
Version 9.1.1
1+
Version 9.1.2
2+
Availability: .NET 9 and .NET 8
3+
 
4+
# ALM
5+
- CHANGED Dependencies to latest and greatest with respect to TFMs
6+
 
7+
Version 9.1.1
28
Availability: .NET 9 and .NET 8
39

410
# ALM

.nuget/Codebelt.Extensions.Xunit.Hosting.AspNetCore/PackageReleaseNotes.txt

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,10 @@
1-
Version 9.1.1
1+
Version 9.1.2
2+
Availability: .NET 9 and .NET 8
3+
 
4+
# ALM
5+
- CHANGED Dependencies to latest and greatest with respect to TFMs
6+
 
7+
Version 9.1.1
28
Availability: .NET 9 and .NET 8
39

410
# ALM

.nuget/Codebelt.Extensions.Xunit.Hosting/PackageReleaseNotes.txt

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,13 @@
1-
Version 9.1.1
1+
Version 9.1.2
2+
Availability: .NET 9, .NET 8 and .NET Standard 2.0
3+
 
4+
# ALM
5+
- CHANGED Dependencies to latest and greatest with respect to TFMs
6+
 
7+
# Bug Fixes
8+
- FIXED HostTest class in the Codebelt.Extensions.Xunit.Hosting namespace to have same behavior as prior to 9.1.0 release (hereby being backward compatible as originally intended)
9+
 
10+
Version 9.1.1
211
Availability: .NET 9, .NET 8 and .NET Standard 2.0
312

413
# ALM

.nuget/Codebelt.Extensions.Xunit/PackageReleaseNotes.txt

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,10 @@
1-
Version 9.1.1
1+
Version 9.1.2
2+
Availability: .NET 9, .NET 8 and .NET Standard 2.0
3+
 
4+
# ALM
5+
- CHANGED Dependencies to latest and greatest with respect to TFMs
6+
 
7+
Version 9.1.1
28
Availability: .NET 9, .NET 8 and .NET Standard 2.0
39

410
# ALM

CHANGELOG.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,13 @@ For more details, please refer to `PackageReleaseNotes.txt` on a per assembly ba
77
> [!NOTE]
88
> Changelog entries prior to version 8.4.0 was migrated from previous versions of Cuemon.Extensions.Xunit, Cuemon.Extensions.Xunit.Hosting, and Cuemon.Extensions.Xunit.Hosting.AspNetCore.
99
10+
## [9.1.2] - 2025-04-03
11+
12+
### Fixed
13+
14+
- HostTest class in the Codebelt.Extensions.Xunit.Hosting namespace to have same behavior as prior to `9.1.0` release (hereby being backward compatible as originally intended)
15+
- Reintroduced `Configure` method to be virtual (brain fart; should have been captured with `9.1.1` release)
16+
1017
## [9.1.1] - 2025-04-01
1118

1219
### Added

Directory.Build.props

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,10 @@
7171
<PackageReference Include="Microsoft.NET.Test.Sdk" />
7272
<PackageReference Include="xunit" />
7373
<PackageReference Include="xunit.runner.console" />
74-
<PackageReference Include="xunit.runner.visualstudio" />
74+
<PackageReference Include="xunit.runner.visualstudio">
75+
<PrivateAssets>all</PrivateAssets>
76+
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
77+
</PackageReference>
7578
<PackageReference Include="coverlet.msbuild">
7679
<PrivateAssets>all</PrivateAssets>
7780
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>

src/Codebelt.Extensions.Xunit.Hosting/HostTest.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ public IHostEnvironment HostingEnvironment
101101
/// </summary>
102102
/// <param name="configuration">The <see cref="IConfiguration"/> initialized by the <see cref="IHost"/>.</param>
103103
/// <param name="environment">The <see cref="IHostEnvironment"/> initialized by the <see cref="IHost"/>.</param>
104-
public void Configure(IConfiguration configuration, IHostEnvironment environment)
104+
public virtual void Configure(IConfiguration configuration, IHostEnvironment environment)
105105
{
106106
Configuration = configuration;
107107
HostingEnvironment = environment;

test/Codebelt.Extensions.Xunit.Tests/DisposableTest.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,8 +81,9 @@ public void UnmanagedDisposable_VerifyThatAssetIsBeingDisposedOnFinalize()
8181
}
8282
finally
8383
{
84-
GC.Collect(0, GCCollectionMode.Forced);
84+
GC.Collect(GC.MaxGeneration, GCCollectionMode.Forced);
8585
GC.WaitForPendingFinalizers();
86+
Task.Delay(500).Wait(); // Add a small delay
8687
}
8788

8889
if (unmanaged.TryGetTarget(out var ud2))

testenvironments.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,12 @@
44
{
55
"name": "WSL-Ubuntu",
66
"type": "wsl",
7-
"wslDistribution": "Ubuntu-22.04"
7+
"wslDistribution": "Ubuntu-24.04"
88
},
99
{
1010
"name": "Docker-Ubuntu",
1111
"type": "docker",
12-
"dockerImage": "gimlichael/ubuntu-testrunner:net8.0.407-9.0.202"
12+
"dockerImage": "gimlichael/ubuntu-testrunner:mono-net8.0.407-9.0.202"
1313
}
1414
]
1515
}

0 commit comments

Comments
 (0)