refactor: DRY role locator handling with helper functions

- Extract isRoleLocatorObject() helper to check for role locator objects
- Extract handleRoleLocator() helper to convert role locators to Playwright getByRole API
- Replace 4 duplicated code blocks with reusable helper functions
- No functional changes - all 16 tests still passing

Author: kobenguyent

lib/helper/Playwright.js

@@ -2822,14 +2822,14 @@ class Playwright extends Helper {
    */
   async grabTextFrom(locator) {
     // Handle role locators with text/exact options
-    if (locator && typeof locator === 'object' && locator.role && !locator.type) {
-      const options = {}
-      if (locator.text) options.name = locator.text
-      if (locator.exact !== undefined) options.exact = locator.exact
-      const text = await this.page.getByRole(locator.role, Object.keys(options).length > 0 ? options : undefined).first().textContent()
-      assertElementExists(text, JSON.stringify(locator))
-      this.debugSection('Text', text)
-      return text
+    if (isRoleLocatorObject(locator)) {
+      const elements = await handleRoleLocator(this.page, locator)
+      if (elements && elements.length > 0) {
+        const text = await elements[0].textContent()
+        assertElementExists(text, JSON.stringify(locator))
+        this.debugSection('Text', text)
+        return text
+      }
     }
 
     const locatorObj = new Locator(locator, 'css')
@@ -4340,6 +4340,27 @@ function buildLocatorString(locator) {
   return locator.simplify()
 }
 
+/**
+ * Checks if a locator is a role locator object (e.g., {role: 'button', text: 'Submit', exact: true})
+ */
+function isRoleLocatorObject(locator) {
+  return locator && typeof locator === 'object' && locator.role && !locator.type
+}
+
+/**
+ * Handles role locator objects by converting them to Playwright's getByRole() API
+ * Returns elements array if role locator, null otherwise
+ */
+async function handleRoleLocator(context, locator) {
+  if (!isRoleLocatorObject(locator)) return null
+  
+  const options = {}
+  if (locator.text) options.name = locator.text
+  if (locator.exact !== undefined) options.exact = locator.exact
+  
+  return context.getByRole(locator.role, Object.keys(options).length > 0 ? options : undefined).all()
+}
+
 async function findElements(matcher, locator) {
   // Check if locator is a Locator object with react/vue type, or a raw object with react/vue property
   const isReactLocator = locator.type === 'react' || (locator.locator && locator.locator.react) || locator.react
@@ -4351,16 +4372,8 @@ async function findElements(matcher, locator) {
   if (isPwLocator) return findByPlaywrightLocator.call(this, matcher, locator)
 
   // Handle role locators with text/exact options (e.g., {role: 'button', text: 'Submit', exact: true})
-  if (locator && typeof locator === 'object' && locator.role && !locator.type) {
-    const options = {}
-    if (locator.text) {
-      options.name = locator.text
-    }
-    if (locator.exact !== undefined) {
-      options.exact = locator.exact
-    }
-    return matcher.getByRole(locator.role, Object.keys(options).length > 0 ? options : undefined).all()
-  }
+  const roleElements = await handleRoleLocator(matcher, locator)
+  if (roleElements) return roleElements
 
   locator = new Locator(locator, 'css')
 
@@ -4610,12 +4623,8 @@ async function findCheckable(locator, context) {
   }
 
   // Handle role locators with text/exact options
-  if (locator && typeof locator === 'object' && locator.role && !locator.type) {
-    const options = {}
-    if (locator.text) options.name = locator.text
-    if (locator.exact !== undefined) options.exact = locator.exact
-    return contextEl.getByRole(locator.role, Object.keys(options).length > 0 ? options : undefined).all()
-  }
+  const roleElements = await handleRoleLocator(contextEl, locator)
+  if (roleElements) return roleElements
 
   const matchedLocator = new Locator(locator)
   if (!matchedLocator.isFuzzy()) {
@@ -4644,12 +4653,10 @@ async function proceedIsChecked(assertType, option) {
 
 async function findFields(locator) {
   // Handle role locators with text/exact options
-  if (locator && typeof locator === 'object' && locator.role && !locator.type) {
-    const options = {}
-    if (locator.text) options.name = locator.text
-    if (locator.exact !== undefined) options.exact = locator.exact
+  if (isRoleLocatorObject(locator)) {
     const page = await this.page
-    return page.getByRole(locator.role, Object.keys(options).length > 0 ? options : undefined).all()
+    const roleElements = await handleRoleLocator(page, locator)
+    if (roleElements) return roleElements
   }
 
   const matchedLocator = new Locator(locator)