Skip to content

⚡️ Speed up function _estimate_min_resource by 141% #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

⚡️ Speed up function _estimate_min_resource by 141% #157

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions optuna/pruners/_successive_halving.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,15 +215,19 @@ def prune(self, study: "optuna.study.Study", trial: "optuna.trial.FrozenTrial")


def _estimate_min_resource(trials: list["optuna.trial.FrozenTrial"]) -> int | None:
n_steps = [
t.last_step for t in trials if t.state == TrialState.COMPLETE and t.last_step is not None
]
# Use a generator and local variable for TrialState for performance.
COMPLETE = TrialState.COMPLETE
n_steps_iter = (t.last_step for t in trials if t.state == COMPLETE and t.last_step is not None)

if not n_steps:
# Loop for max search avoiding extra list allocation.
last_step = None
for step in n_steps_iter:
if last_step is None or step > last_step:
last_step = step

if last_step is None:
return None

# Get the maximum number of steps and divide it by 100.
last_step = max(n_steps)
return max(last_step // 100, 1)


Expand Down