Skip to content

Commit dede45e

Browse files
feat: support creation of apps with empty dir
1 parent a858ad3 commit dede45e

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

event_reporter/reporter/application_event_reporter.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,11 +125,15 @@ func (r *applicationEventReporter) getDesiredManifests(ctx context.Context, a *a
125125
})
126126
if err != nil {
127127
notManifestGenerationError := !strings.Contains(err.Error(), "Manifest generation error")
128+
129+
// we can ignore the error
130+
notAppPathDoesntExistsError := !strings.Contains(err.Error(), "app path does not exist")
131+
128132
// when application deleted rbac also throws erorr with PermissionDenied
129133
// we can ignore the error, as we check rbac access before reporting events
130134
notPermissionDeniedError := !strings.Contains(err.Error(), "PermissionDenied")
131135

132-
if notManifestGenerationError && notPermissionDeniedError {
136+
if notManifestGenerationError && notPermissionDeniedError && notAppPathDoesntExistsError {
133137
return nil, fmt.Errorf("failed to get application desired state manifests: %w", err), false
134138
}
135139
// if it's manifest generation error we need to still report the actual state

0 commit comments

Comments
 (0)