Autofix all issues

mrcasals · mrcasals · commit 809fe1d77fb0 · 2019-07-09T08:55:36.000+02:00
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -1,7 +1,7 @@
 inherit_from: .rubocop_todo.yml
 
 AllCops:
-  TargetRubyVersion: 2.2
+  TargetRubyVersion: 2.3
 
 Metrics/BlockLength:
   ExcludedMethods: [it, describe]
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
@@ -52,6 +52,6 @@ Style/DoubleNegation:
     - 'lib/hyperclient/link.rb'
 
 # Offense count: 1
-Style/MethodMissing:
+Style/MethodMissingSuper:
   Exclude:
     - 'lib/hyperclient/collection.rb'
diff --git a/Dangerfile b/Dangerfile
@@ -1,2 +1,4 @@
+# frozen_string_literal: true
+
 changelog.check
 toc.check
diff --git a/Gemfile b/Gemfile
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # NOTE: this is temporary until Bundler 2.0 changes how github: references work.
 git_source(:github) { |repo| "https://github.com/#{repo['/'] ? repo : "#{repo}/#{repo}"}.git" }
 
diff --git a/Guardfile b/Guardfile
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 guard 'minitest' do
   watch(%r{^test/(.*)_test\.rb})
   watch(%r{^lib/(.*)([^/]+)\.rb})     { |m| "test/#{m[1]}#{m[2]}_test.rb" }
diff --git a/Rakefile b/Rakefile
@@ -1,4 +1,6 @@
 #!/usr/bin/env rake
+# frozen_string_literal: true
+
 require 'rubygems'
 require 'bundler'
 Bundler.setup :default, :test, :development
diff --git a/examples/splines_api.rb b/examples/splines_api.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'hyperclient'
 
 puts "Using Hyperclient #{Hyperclient::VERSION} ..."
diff --git a/features/steps/api_navigation.rb b/features/steps/api_navigation.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Spinach::Features::ApiNavigation < Spinach::FeatureSteps
   include API
 
diff --git a/features/steps/default_config.rb b/features/steps/default_config.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Spinach::Features::DefaultConfig < Spinach::FeatureSteps
   include API
 
diff --git a/features/support/api.rb b/features/support/api.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'fixtures'
 module API
   include Spinach::DSL
diff --git a/features/support/env.rb b/features/support/env.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'minitest/spec'
 require 'webmock'
 WebMock.enable!
diff --git a/features/support/fixtures.rb b/features/support/fixtures.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'json'
 
 module Spinach
diff --git a/hyperclient.gemspec b/hyperclient.gemspec
@@ -1,5 +1,6 @@
+# frozen_string_literal: true
 
-require File.expand_path('../lib/hyperclient/version', __FILE__)
+require File.expand_path('lib/hyperclient/version', __dir__)
 
 Gem::Specification.new do |gem|
   gem.authors       = ['Oriol Gual']
@@ -14,10 +15,10 @@ Gem::Specification.new do |gem|
   gem.require_paths = ['lib']
   gem.version       = Hyperclient::VERSION
 
+  gem.add_dependency 'addressable'
   gem.add_dependency 'faraday', '>= 0.9.0'
-  gem.add_dependency 'faraday_middleware'
+  gem.add_dependency 'faraday-digestauth'
   gem.add_dependency 'faraday_hal_middleware'
-  gem.add_dependency 'addressable'
+  gem.add_dependency 'faraday_middleware'
   gem.add_dependency 'net-http-digest_auth'
-  gem.add_dependency 'faraday-digestauth'
 end
diff --git a/lib/faraday/connection.rb b/lib/faraday/connection.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'faraday'
 require 'faraday/digestauth'
 
diff --git a/lib/hyperclient.rb b/lib/hyperclient.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'hyperclient/collection'
 require 'hyperclient/link'
 require 'hyperclient/attributes'
diff --git a/lib/hyperclient/attributes.rb b/lib/hyperclient/attributes.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Hyperclient
   # Public: A wrapper class to easily acces the attributes in a Resource.
   #
diff --git a/lib/hyperclient/collection.rb b/lib/hyperclient/collection.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Hyperclient
   # Public: A helper class to wrap a collection of elements and provide
   # Hash-like access or via a method call.
diff --git a/lib/hyperclient/curie.rb b/lib/hyperclient/curie.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Hyperclient
   # Internal: Curies are named tokens that you can define in the document and use
   # to express curie relation URIs in a friendlier, more compact fashion.
@@ -41,7 +43,8 @@ def inspect
     # Returns a new expanded url.
     def expand(rel)
       return rel unless rel && templated?
-      href.gsub('{rel}', rel) if href
+
+      href&.gsub('{rel}', rel)
     end
   end
 end
diff --git a/lib/hyperclient/entry_point.rb b/lib/hyperclient/entry_point.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'faraday_middleware'
 require 'faraday_hal_middleware'
 require_relative '../faraday/connection'
@@ -57,6 +59,7 @@ def connection(options = {}, &block)
       @faraday_options ||= options.dup
       if block_given?
         raise ConnectionAlreadyInitializedError if @connection
+
         @faraday_block = if @faraday_options.delete(:default) == false
                            block
                          else
@@ -75,6 +78,7 @@ def connection(options = {}, &block)
     # Returns a Hash.
     def headers
       return @connection.headers if @connection
+
       @headers ||= default_headers
     end
 
@@ -83,6 +87,7 @@ def headers
     # value    - A Hash containing headers to include with every API request.
     def headers=(value)
       raise ConnectionAlreadyInitializedError if @connection
+
       @headers = value
     end
 
@@ -98,6 +103,7 @@ def faraday_options
     # value    - A Hash containing options to pass to Faraday
     def faraday_options=(value)
       raise ConnectionAlreadyInitializedError if @connection
+
       @faraday_options = value
     end
 
@@ -113,6 +119,7 @@ def faraday_block
     # value    - A Proc accepting a Faraday::Connection.
     def faraday_block=(value)
       raise ConnectionAlreadyInitializedError if @connection
+
       @faraday_block = value
     end
 
diff --git a/lib/hyperclient/link.rb b/lib/hyperclient/link.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'addressable'
 
 module Hyperclient
@@ -39,6 +41,7 @@ def _expand(uri_variables = {})
     # Public: Returns the url of the Link.
     def _url
       return @link['href'] unless _templated?
+
       @url ||= _uri_template.expand(@uri_variables || {}).to_s
     end
 
@@ -137,8 +140,10 @@ def method_missing(method, *args, &block)
     # This allows `api.posts` instead of `api._links.posts.embedded.posts`
     def delegate_method(method, *args, &block)
       return unless @key && _resource.respond_to?(@key)
+
       @delegate ||= _resource.send(@key)
-      return unless @delegate && @delegate.respond_to?(method.to_s)
+      return unless @delegate&.respond_to?(method.to_s)
+
       @delegate.send(method, *args, &block)
     end
 
diff --git a/lib/hyperclient/link_collection.rb b/lib/hyperclient/link_collection.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Hyperclient
   # Public: A wrapper class to easily acces the links in a  Resource.
   #
diff --git a/lib/hyperclient/resource.rb b/lib/hyperclient/resource.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'forwardable'
 
 module Hyperclient
@@ -55,11 +57,11 @@ def inspect
     end
 
     def _success?
-      _response && _response.success?
+      _response&.success?
     end
 
     def _status
-      _response && _response.status
+      _response&.status
     end
 
     def [](name)
diff --git a/lib/hyperclient/resource_collection.rb b/lib/hyperclient/resource_collection.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Hyperclient
   # Public: A wrapper class to easily acces the embedded resources in a
   # Resource.
diff --git a/lib/hyperclient/version.rb b/lib/hyperclient/version.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Hyperclient
-  VERSION = '0.9.1'.freeze
+  VERSION = '0.9.1'
 end
diff --git a/test/faraday/connection_test.rb b/test/faraday/connection_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../test_helper'
 require_relative '../../lib/faraday/connection'
 
diff --git a/test/hyperclient/attributes_test.rb b/test/hyperclient/attributes_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../test_helper'
 require 'hyperclient'
 
diff --git a/test/hyperclient/collection_test.rb b/test/hyperclient/collection_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../test_helper'
 require 'hyperclient'
 
diff --git a/test/hyperclient/curie_test.rb b/test/hyperclient/curie_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../test_helper'
 require 'hyperclient'
 
diff --git a/test/hyperclient/entry_point_test.rb b/test/hyperclient/entry_point_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../test_helper'
 require 'hyperclient'
 
diff --git a/test/hyperclient/link_collection_test.rb b/test/hyperclient/link_collection_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../test_helper'
 require 'hyperclient'
 
diff --git a/test/hyperclient/link_test.rb b/test/hyperclient/link_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../test_helper'
 require 'hyperclient'
 
diff --git a/test/hyperclient/resource_collection_test.rb b/test/hyperclient/resource_collection_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../test_helper'
 require 'hyperclient'
 
diff --git a/test/hyperclient/resource_test.rb b/test/hyperclient/resource_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../test_helper'
 require 'hyperclient'
 
diff --git a/test/hyperclient_test.rb b/test/hyperclient_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 require 'hyperclient'
 
diff --git a/test/test_helper.rb b/test/test_helper.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 $LOAD_PATH << 'lib'
 
 require 'minitest/spec'

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+# frozen_string_literal: true`
	`2`	`+`
`1`	`3`	`# NOTE: this is temporary until Bundler 2.0 changes how github: references work.`
`2`	`4`	`git_source(:github) { \|repo\| "https://github.com/#{repo['/'] ? repo : "#{repo}/#{repo}"}.git" }`
`3`	`5`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+# frozen_string_literal: true`
	`2`	`+`
`1`	`3`	`guard 'minitest' do`
`2`	`4`	`watch(%r{^test/(.*)_test\.rb})`
`3`	`5`	`watch(%r{^lib/(.*)([^/]+)\.rb}) { \|m\| "test/#{m[1]}#{m[2]}_test.rb" }`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+# frozen_string_literal: true`
	`2`	`+`
`1`	`3`	`require 'hyperclient'`
`2`	`4`
`3`	`5`	`puts "Using Hyperclient #{Hyperclient::VERSION} ..."`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+# frozen_string_literal: true`
	`2`	`+`
`1`	`3`	`class Spinach::Features::ApiNavigation < Spinach::FeatureSteps`
`2`	`4`	`include API`
`3`	`5`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+# frozen_string_literal: true`
	`2`	`+`
`1`	`3`	`class Spinach::Features::DefaultConfig < Spinach::FeatureSteps`
`2`	`4`	`include API`
`3`	`5`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+# frozen_string_literal: true`
	`2`	`+`
`1`	`3`	`require_relative 'fixtures'`
`2`	`4`	`module API`
`3`	`5`	`include Spinach::DSL`