refactor: fix used void return type (#9341)

Author: paulbalandan

system/Commands/ListCommands.php

@@ -71,22 +71,24 @@ class ListCommands extends BaseCommand
 
     /**
      * Displays the help for the spark cli script itself.
+     *
+     * @return int
      */
     public function run(array $params)
     {
         $commands = $this->commands->getCommands();
         ksort($commands);
 
         // Check for 'simple' format
-        return array_key_exists('simple', $params) || CLI::getOption('simple')
+        return array_key_exists('simple', $params) || CLI::getOption('simple') === true
             ? $this->listSimple($commands)
             : $this->listFull($commands);
     }
 
     /**
      * Lists the commands with accompanying info.
      *
-     * @return void
+     * @return int
      */
     protected function listFull(array $commands)
     {
@@ -124,17 +126,21 @@ protected function listFull(array $commands)
                 CLI::newLine();
             }
         }
+
+        return EXIT_SUCCESS;
     }
 
     /**
      * Lists the commands only.
      *
-     * @return void
+     * @return int
      */
     protected function listSimple(array $commands)
     {
         foreach (array_keys($commands) as $title) {
             CLI::write($title);
         }
+
+        return EXIT_SUCCESS;
     }
 }

tests/system/Log/LoggerTest.php

@@ -20,6 +20,8 @@
 use CodeIgniter\Test\Mock\MockLogger as LoggerConfig;
 use Exception;
 use PHPUnit\Framework\Attributes\Group;
+use ReflectionMethod;
+use ReflectionNamedType;
 use Tests\Support\Log\Handlers\TestHandler;
 use TypeError;
 
@@ -67,7 +69,10 @@ public function testLogAlwaysReturnsVoid(): void
 
         $logger = new Logger($config);
 
-        $this->assertNull($logger->log('debug', ''));
+        $refMethod = new ReflectionMethod($logger, 'log');
+        $this->assertTrue($refMethod->hasReturnType());
+        $this->assertInstanceOf(ReflectionNamedType::class, $refMethod->getReturnType());
+        $this->assertSame('void', $refMethod->getReturnType()->getName());
     }
 
     public function testLogActuallyLogs(): void

utils/phpstan-baseline/loader.neon

@@ -37,7 +37,6 @@ includes:
     - method.impossibleType.neon
     - method.notFound.neon
     - method.unused.neon
-    - method.void.neon
     - missingType.callable.neon
     - missingType.iterableValue.neon
     - missingType.parameter.neon