Merge pull request #9345 from codeigniter4/develop

4.5.6 Ready code

Author: paulbalandan

.github/workflows/deploy-distributables.yml

@@ -159,11 +159,15 @@ jobs:
           token: ${{ secrets.ACCESS_TOKEN }}
           path: userguide
 
+      - name: Setup Python
+        uses: actions/setup-python@v5
+        with:
+          python-version: '3.12'
+
       - name: Install Sphinx
         run: |
-          sudo apt install python3-sphinx
-          sudo pip3 install sphinxcontrib-phpdomain
-          sudo pip3 install sphinx_rtd_theme
+          python -m pip install --upgrade pip
+          pip install -r ./source/user_guide_src/requirements.txt
 
       - name: Chmod
         run: chmod +x ./source/.github/scripts/deploy-userguide

.github/workflows/deploy-userguide-latest.yml

@@ -33,11 +33,20 @@ jobs:
           php-version: '8.1'
           coverage: none
 
-      # Build the latest User Guide
-      - name: Build with Sphinx
-        uses: ammaraskar/[email protected]
+      - name: Setup Python
+        uses: actions/setup-python@v5
         with:
-          docs-folder: user_guide_src/
+          python-version: '3.12'
+
+      - name: Install Sphinx
+        run: |
+          python -m pip install --upgrade pip
+          pip install -r user_guide_src/requirements.txt
+
+      # Build the latest User Guide
+      - name: Build Docs with Sphinx
+        run: make html
+        working-directory: user_guide_src
 
       - name: Add "Edit this page" links
         run: |

.github/workflows/reusable-coveralls.yml

@@ -13,6 +13,12 @@ jobs:
     runs-on: ubuntu-22.04
 
     steps:
+      - name: Checkout base branch for PR
+        if: github.event_name == 'pull_request'
+        uses: actions/checkout@v4
+        with:
+          ref: ${{ github.base_ref }}
+
       - name: Checkout
         uses: actions/checkout@v4
 

.github/workflows/reusable-phpunit-test.yml

@@ -138,7 +138,7 @@ jobs:
     steps:
       - name: Create database for MSSQL Server
         if: ${{ inputs.db-platform == 'SQLSRV' }}
-        run: sqlcmd -S 127.0.0.1 -U sa -P 1Secure*Password1 -Q "CREATE DATABASE test"
+        run: sqlcmd -S 127.0.0.1 -U sa -P 1Secure*Password1 -Q "CREATE DATABASE test COLLATE Latin1_General_100_CS_AS_SC_UTF8"
 
       - name: Install latest ImageMagick
         if: ${{ contains(inputs.extra-extensions, 'imagick') }}
@@ -148,6 +148,12 @@ jobs:
           sudo apt-get install -y gsfonts libmagickwand-dev imagemagick
           sudo apt-get install --fix-broken
 
+      - name: Checkout base branch for PR
+        if: github.event_name == 'pull_request'
+        uses: actions/checkout@v4
+        with:
+          ref: ${{ github.base_ref }}
+
       - name: Checkout
         uses: actions/checkout@v4
 

.github/workflows/reusable-serviceless-phpunit-test.yml

@@ -60,6 +60,12 @@ jobs:
           sudo apt-get install -y imagemagick
           sudo apt-get install --fix-broken
 
+      - name: Checkout base branch for PR
+        if: github.event_name == 'pull_request'
+        uses: actions/checkout@v4
+        with:
+          ref: ${{ github.base_ref }}
+
       - name: Checkout
         uses: actions/checkout@v4
 

.github/workflows/test-autoreview.yml

@@ -35,6 +35,12 @@ jobs:
     name: Check normalized composer.json
     runs-on: ubuntu-latest
     steps:
+      - name: Checkout base branch for PR
+        if: github.event_name == 'pull_request'
+        uses: actions/checkout@v4
+        with:
+          ref: ${{ github.base_ref }}
+
       - name: Checkout
         uses: actions/checkout@v4
 

.github/workflows/test-coding-standards.yml

@@ -32,6 +32,12 @@ jobs:
           - '8.3'
 
     steps:
+      - name: Checkout base branch for PR
+        if: github.event_name == 'pull_request'
+        uses: actions/checkout@v4
+        with:
+          ref: ${{ github.base_ref }}
+
       - name: Checkout
         uses: actions/checkout@v4
 

.github/workflows/test-deptrac.yml

@@ -36,6 +36,12 @@ jobs:
     name: Architectural Inspection
     runs-on: ubuntu-22.04
     steps:
+      - name: Checkout base branch for PR
+        if: github.event_name == 'pull_request'
+        uses: actions/checkout@v4
+        with:
+          ref: ${{ github.base_ref }}
+
       - name: Checkout
         uses: actions/checkout@v4
 

.github/workflows/test-phpstan.yml

@@ -45,6 +45,12 @@ jobs:
     strategy:
       fail-fast: false
     steps:
+      - name: Checkout base branch for PR
+        if: github.event_name == 'pull_request'
+        uses: actions/checkout@v4
+        with:
+          ref: ${{ github.base_ref }}
+
       - name: Checkout
         uses: actions/checkout@v4
 

.github/workflows/test-psalm.yml

@@ -27,6 +27,12 @@ jobs:
     if: (! contains(github.event.head_commit.message, '[ci skip]'))
 
     steps:
+      - name: Checkout base branch for PR
+        if: github.event_name == 'pull_request'
+        uses: actions/checkout@v4
+        with:
+          ref: ${{ github.base_ref }}
+
       - name: Checkout
         uses: actions/checkout@v4