refactor: remove finfo_close has no effect since PHP 8.0

ddevsr · ddevsr · commit cee6dd5882da · 2025-08-19T17:26:52.000+07:00
refactor: remove `finfo_close` has no effect since PHP 8.0
diff --git a/system/Files/File.php b/system/Files/File.php
@@ -133,11 +133,9 @@ public function getMimeType(): string
             return $this->originalMimeType ?? 'application/octet-stream'; // @codeCoverageIgnore
         }
 
-        $finfo    = finfo_open(FILEINFO_MIME_TYPE);
-        $mimeType = finfo_file($finfo, $this->getRealPath() ?: $this->__toString());
-        finfo_close($finfo);
+        $finfo = finfo_open(FILEINFO_MIME_TYPE);
 
-        return $mimeType;
+        return finfo_file($finfo, $this->getRealPath() ?: $this->__toString());
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -133,11 +133,9 @@ public function getMimeType(): string`
`133`	`133`	`return $this->originalMimeType ?? 'application/octet-stream'; // @codeCoverageIgnore`
`134`	`134`	`}`
`135`	`135`
`136`		`- $finfo = finfo_open(FILEINFO_MIME_TYPE);`
`137`		`- $mimeType = finfo_file($finfo, $this->getRealPath() ?: $this->__toString());`
`138`		`- finfo_close($finfo);`
	`136`	`+ $finfo = finfo_open(FILEINFO_MIME_TYPE);`
`139`	`137`
`140`		`- return $mimeType;`
	`138`	`+ return finfo_file($finfo, $this->getRealPath() ?: $this->__toString());`
`141`	`139`	`}`
`142`	`140`
`143`	`141`	`/**`