Skip to content

functional points #71

@Cody-Price

Description

@Cody-Price
  • do not keep password in redux client side (only backend)
  • do not keep entire piece of data in favorites array, only put a reference to the actual data (i.e. id)
  • try and keep action name and type the same if possible
  • isLoading should be more specific to what is loading (this is for developer empathy)
  • move all test files into tests files
  • LOGOUT_USER type in favorites reducer should not be used there, create separate action that clears favorites 'CLEAR_FAVORITES'
  • toggleFavorite (inside of the Card component) should be moved into a helper or function inside of a functional component
  • card has too many 'this.props' should be destructuring if using too many.
  • testing for mapStateToProps should have one more property than you are using in said container (that way you are testing that it can pull out only the ones you are specifying)
  • test App!

Metadata

Metadata

Assignees

No one assigned

    Labels

    future workSomething to fix/implement in a refactor

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions