Skip to content

Log to GitLab when the job handler cannot be created #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Log to GitLab when the job handler cannot be created #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ async fn main() {
|job| async {
ObsJobHandler::from_obs_config_in_job(job, HandlerOptions::default()).map_err(
|err| {
error!("Failed to create new client: {:?}", err);
error!(gitlab.output = true, "Failed to handle new job: {:?}", err);
Copy link
Contributor

@sjoerdsimons sjoerdsimons Oct 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gitlab.output is really an implementation detail that crates using the runner shouldn't be aware of :). If you use outputln! it will already do the right thing; If you want and equivalent of e.g. error! then that's something to look at in the gitlab runner crate really.

},
)
},
Expand Down