From 309d2b8ad193947d39eedbe922b7586df30e6d43 Mon Sep 17 00:00:00 2001
From: gareth-odyssey <gareth@odyssey.systems>
Date: Mon, 14 Apr 2025 22:01:54 +0000
Subject: [PATCH] Remove broken argument registration in glomap

---
 glomap/controllers/option_manager.cc |  5 -----
 glomap/controllers/option_manager.h  | 26 --------------------------
 2 files changed, 31 deletions(-)

diff --git a/glomap/controllers/option_manager.cc b/glomap/controllers/option_manager.cc
index 3a7c8ff..1433953 100644
--- a/glomap/controllers/option_manager.cc
+++ b/glomap/controllers/option_manager.cc
@@ -286,11 +286,6 @@ void OptionManager::Reset() {
 
   desc_ = std::make_shared<boost::program_options::options_description>();
 
-  options_bool_.clear();
-  options_int_.clear();
-  options_double_.clear();
-  options_string_.clear();
-
   added_mapper_options_ = false;
   added_view_graph_calibration_options_ = false;
   added_relative_pose_options_ = false;
diff --git a/glomap/controllers/option_manager.h b/glomap/controllers/option_manager.h
index 030d38e..7c14dea 100644
--- a/glomap/controllers/option_manager.h
+++ b/glomap/controllers/option_manager.h
@@ -70,16 +70,8 @@ class OptionManager {
                                    T* option,
                                    const std::string& help_text = "");
 
-  template <typename T>
-  void RegisterOption(const std::string& name, const T* option);
-
   std::shared_ptr<boost::program_options::options_description> desc_;
 
-  std::vector<std::pair<std::string, const bool*>> options_bool_;
-  std::vector<std::pair<std::string, const int*>> options_int_;
-  std::vector<std::pair<std::string, const double*>> options_double_;
-  std::vector<std::pair<std::string, const std::string*>> options_string_;
-
   bool added_database_options_ = false;
   bool added_image_options_ = false;
   bool added_mapper_options_ = false;
@@ -120,7 +112,6 @@ void OptionManager::AddAndRegisterRequiredOption(const std::string& name,
   desc_->add_options()(name.c_str(),
                        boost::program_options::value<T>(option)->required(),
                        help_text.c_str());
-  RegisterOption(name, option);
 }
 
 template <typename T>
@@ -131,23 +122,6 @@ void OptionManager::AddAndRegisterDefaultOption(const std::string& name,
       name.c_str(),
       boost::program_options::value<T>(option)->default_value(*option),
       help_text.c_str());
-  RegisterOption(name, option);
-}
-
-template <typename T>
-void OptionManager::RegisterOption(const std::string& name, const T* option) {
-  if (std::is_same<T, bool>::value) {
-    options_bool_.emplace_back(name, reinterpret_cast<const bool*>(option));
-  } else if (std::is_same<T, int>::value) {
-    options_int_.emplace_back(name, reinterpret_cast<const int*>(option));
-  } else if (std::is_same<T, double>::value) {
-    options_double_.emplace_back(name, reinterpret_cast<const double*>(option));
-  } else if (std::is_same<T, std::string>::value) {
-    options_string_.emplace_back(name,
-                                 reinterpret_cast<const std::string*>(option));
-  } else {
-    LOG(ERROR) << "Unsupported option type: " << name;
-  }
 }
 
 }  // namespace glomap