Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update get-svg-colors to fix the is-svg dependency security issue #25

Closed
carloscuesta opened this issue May 11, 2021 · 5 comments · Fixed by #28
Closed

Update get-svg-colors to fix the is-svg dependency security issue #25

carloscuesta opened this issue May 11, 2021 · 5 comments · Fixed by #28

Comments

@carloscuesta
Copy link
Contributor

Hello! 👋🏼

This is related with colorjs/get-svg-colors#72. The is-svg dependency used by get-svg-colors has a vulnerability, I already opened a PR to fix it colorjs/get-svg-colors#73, as soon as we merge and release this we should update the dependency 😊

@adityapatadia
Copy link

@zeke can you release new version?

@zeke
Copy link
Member

zeke commented Feb 4, 2022

Hey color lovers!

Sorry I missed this and thanks for pinging me by name, @adityapatadia. I just published a new major version 2.0.0, in case there were any breaking changes since the last release (I didn't look too closely).

$ np 2.0.0 --no-2fa  

  ✔ Prerequisite check
  ✔ Git
  ✔ Cleanup
  ✔ Installing dependencies using npm
  ✔ Running tests using npm
  ✔ Bumping version using npm
  ✔ Publishing package using npm
  ✔ Pushing tags
  ✔ Creating release draft on GitHub

 get-svg-colors 2.0.0 published 🎉

@zeke zeke closed this as completed Feb 4, 2022
@adityapatadia
Copy link

adityapatadia commented Feb 4, 2022

Thanks for quickly getting this released. The problem is that current repo still installs ^1.5.1. Can you update this repo as well to include 2.0.0?

@carloscuesta
Copy link
Contributor Author

Created a PR to update the dependency in this repo as well: #28

@zeke
Copy link
Member

zeke commented Feb 4, 2022

Sorry I was a bit hasty and didn't notice which repo I was looking at, git-image-colors vs get-svg-colors. 🙈

Just released a new version with the updated dep:

base $ np patch --no-2fa         

Commits:
- remove package lock  33fe744
- Update `get-svg-colors` dependency (#28)  26ad4bd

Commit Range:
v4.0.0...master

  ✔ Prerequisite check
  ✔ Git
  ✔ Cleanup
  ✔ Installing dependencies using npm
  ✔ Running tests using npm
  ✔ Bumping version using npm
  ✔ Publishing package using npm
  ✔ Pushing tags
  ✔ Creating release draft on GitHub

 get-image-colors 4.0.1 published 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants