-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How can I get more than 5 colors from an image? #8
Comments
We'd need to update this line: https://github.com/zeke/get-image-colors/blob/master/index.js#L40 Simplest thing would be to just bump the value to something. I think I chose 5 because the accuracy diminishes quickly. Care to submit a PR that changes this? If not, I can do it. |
The number could be a parameter to the function, but that doesn't seem ideal to me. I think we should just return more results and mention in the readme that mileage may vary. |
Ok thanks sounds good I was able to bump that number to 15 and get good results. Optional first arg to function seems workable but just bumping higher is great. Appreciate the quick attention!
…Sent from my iPhone
On Mar 9, 2017, at 5:48 PM, Zeke Sikelianos ***@***.***> wrote:
The number could be a parameter to the function, but that doesn't seem ideal to me.
I think we should just return more results and mention in the readme that mileage may vary.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
I think having it as parameter with a decent default is the best. This way this can support all use cases! |
Okay I'll do that and cut a new release in a bit. |
Following up on this? Curious if it was added |
Gah. Sorry I dropped the ball on this. Might not get to it until next week, but if someone wants to open a PR with this change I can ship it quickly. |
Looks like this is addressed here? |
It's been a long time coming, but this #15 finally landed in a new release 2.0.0. Thanks for your patience folks, and props to @YouTwitFace for the fix. |
Would be very helpful thank you!
The text was updated successfully, but these errors were encountered: