Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How can I get more than 5 colors from an image? #8

Closed
alanweissman opened this issue Mar 9, 2017 · 11 comments
Closed

How can I get more than 5 colors from an image? #8

alanweissman opened this issue Mar 9, 2017 · 11 comments

Comments

@alanweissman
Copy link

Would be very helpful thank you!

@zeke
Copy link
Member

zeke commented Mar 9, 2017

We'd need to update this line: https://github.com/zeke/get-image-colors/blob/master/index.js#L40

Simplest thing would be to just bump the value to something. I think I chose 5 because the accuracy diminishes quickly.

Care to submit a PR that changes this? If not, I can do it.

@zeke
Copy link
Member

zeke commented Mar 9, 2017

The number could be a parameter to the function, but that doesn't seem ideal to me.

I think we should just return more results and mention in the readme that mileage may vary.

@alanweissman
Copy link
Author

alanweissman commented Mar 10, 2017 via email

@kilianc
Copy link

kilianc commented Aug 3, 2017

I think having it as parameter with a decent default is the best. This way this can support all use cases!

@zeke
Copy link
Member

zeke commented Aug 3, 2017

Okay I'll do that and cut a new release in a bit.

@TheRyanHickman
Copy link

Following up on this? Curious if it was added

@zeke
Copy link
Member

zeke commented Oct 13, 2017

Gah. Sorry I dropped the ball on this. Might not get to it until next week, but if someone wants to open a PR with this change I can ship it quickly.

@clwheeler
Copy link

Looks like this is addressed here?
#12

@dougmolineux
Copy link

+1 would love to see this feature, I can work on adding it @zeke if you don't want to merge in all of #12

@vrumger
Copy link
Contributor

vrumger commented Nov 26, 2018

@zeke #15

@zeke
Copy link
Member

zeke commented Jan 4, 2019

It's been a long time coming, but this #15 finally landed in a new release 2.0.0.

Thanks for your patience folks, and props to @YouTwitFace for the fix.

@zeke zeke closed this as completed Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants