You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fix relevant components discovery and add support for ArgoCD "native" application discovery (#8)
* Use telefonistka in-pr metadata mechanism to pass changed component path
to ArgoCD diff functionality
* Add some validation to avoid auto-merging PRs in cases telefonistka is
unsure of the component that where changed
* Support two way to fetch matching ArgoCD apps from a Telefonistka
component the telefonistka dedicated sha1 label and the ArgoCD native
`manifest-generate-paths` annotation
* Fix relevant components discovery hannes (#9)
* mocks: use go run to reduce dependency
Using go run will automatically install the tool and run it if it is not
installed already.
* argocd: fix import path
The import path for the mocks package is incorrect causing errors.
The mocks package should be imported from internal/pkg/mocks instead of
mocks/argocd.
This also removes the aliased import and uses the package as named,
which aligns with the directory name.
---------
Co-authored-by: Hannes Gustafsson <[email protected]>
* Add needed argodiff.NewDiffConfigBuilder param (after version upgrade)
Log time of API call with questionable performance :)
* Fix typo and add code generate step to makefile
* Lint fixes, fix gitignore.
upsate go.mod
* Hack go genrate for linting
* Cleanup and try to use make file config
* Document new configuration key
* Update argocd_test.go - remove some editor completion artifacts
* Fix two "bad conflict resolution" issues
* Apply suggestions from code review
Co-authored-by: Yazdan Mohammadi <[email protected]>
* I fix var name typo
* Rename client var names
---------
Co-authored-by: Hannes Gustafsson <[email protected]>
Co-authored-by: Yazdan Mohammadi <[email protected]>
Copy file name to clipboardexpand all lines: docs/installation.md
+1
Original file line number
Diff line number
Diff line change
@@ -119,6 +119,7 @@ Configuration keys:
119
119
|`toggleCommitStatus`| Map of strings, allow (non-repo-admin) users to change the [Github commit status](https://docs.github.com/en/rest/commits/statuses) state(from failure to success and back). This can be used to continue promotion of a change that doesn't pass repo checks. the keys are strings commented in the PRs, values are [Github commit status context](https://docs.github.com/en/rest/commits/statuses?apiVersion=2022-11-28#create-a-commit-status) to be overridden|
120
120
|`commentArgocdDiffonPR`| Uses ArgoCD API to calculate expected changes to k8s state and comment the resulting "diff" as comment in the PR. Requires ARGOCD_* environment variables, see below. |
121
121
|`autoMergeNoDiffPRs`| if true, Telefonistka will **merge** promotion PRs that are not expected to change the target clusters. Requires `commentArgocdDiffonPR` and possibly `autoApprovePromotionPrs`(depending on repo branch protection rules)|
122
+
|`useSHALabelForArgoDicovery`| The default method for discovering relevant ArgoCD applications (for a PR) relies on fetching all applications in the repo and checking the `argocd.argoproj.io/manifest-generate-paths` **annotation**, this might cause a performance issue on a repo with a large number of ArgoCD applications. The alternative is to add SHA1 of the application path as a **label** and rely on ArgoCD server-side filtering, label name is `telefonistka.io/component-path-sha1`.|
0 commit comments