Skip to content

Releases: commercetools/telefonistka

v1.6.0

25 Oct 09:34
9b32fb1
Compare
Choose a tag to compare
SD-838: fix panic (#33)

* Fix potential panic

The change [1] introduced a potential panic as it is trying to log the
app name when a failure happens, but the app variable is overridden
during such a failure and is thus nil.

This results in the following panic.

    panic: runtime error: invalid memory address or nil pointer dereference
    [signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x20ddccb]

    goroutine 367 [running]:
    internal/pkg/argocd.generateDiffOfAComponent()
	    internal/pkg/argocd/argocd.go:477
    internal/pkg/argocd.GenerateDiffOfChangedComponents()
	    internal/pkg/argocd/argocd.go:561
    internal/pkg/githubapi.HandlePREvent()
	    internal/pkg/githubapi/github.go:161
    internal/pkg/githubapi.handleEvent()
	    internal/pkg/githubapi/github.go:382
    created by internal/pkg/githubapi.ReciveWebhook
	    internal/pkg/githubapi/github.go:322

By instead using the name from the query constructed prior, the panic
should be avoided.

[1] adbd91328b2edce48ee4607f101ecb2b6528d77b

v1.5.0

23 Oct 13:38
33715e7
Compare
Choose a tag to compare

What's Changed

Full Changelog: v1.4.0...v1.5.0

v1.4.0

18 Oct 14:33
caaf793
Compare
Choose a tag to compare
Sd 766 telefonistka get nil pointer dereference when it tries to diff…

v1.3.0

16 Sep 07:54
d60f34e
Compare
Choose a tag to compare
Split too big comment per cluster (#22)

* Split too big comment per cluster

If a "regular" aggregate diff can't fit in a GH comment create one
comment per cluster.
There's still a fallback to concise diff (just lists changed objects)
for extreme cases

* Move logging out of executeTemplate to higher up the stack
Create a new "testable"  generateArgoCdDiffComments function to generate
all the comments content

Comment all the comments

* Add test for 3 "levels" of comments

* Apply suggestions from code review

Co-authored-by: Hannes Gustafsson <[email protected]>

v1.2.0

09 Sep 12:29
bbe49ea
Compare
Choose a tag to compare

What's Changed

  • fix intermittent test failures caused by the TestAggregatePromotionPlan test by @jared-logan-patrick-ct in #24
  • Help user to debug the diff error with temporary applications by @yzdann in #26

New Contributors

Full Changelog: v1.1.0...v1.2.0

v1.1.0

06 Sep 07:59
4a14b34
Compare
Choose a tag to compare

What's Changed

New Contributors

Full Changelog: v1.0.2...v1.1.0

v1.0.2

03 Sep 13:40
2f5c16e
Compare
Choose a tag to compare

What's Changed

  • Provide the complete name of target cluster in promotion PRs. Improves the formatting of target paths in the promotion PR body. The full target paths are now joined with a newline and indentation for better readability in PR #21

New Contributors

Full Changelog: v1.0.1...v1.0.2

v1.0.1

06 Aug 12:06
9ab1dd8
Compare
Choose a tag to compare
Use "concise" diff comment in cases "regular" diff comment is > 65536…

v1.0.0

24 Jul 14:45
adbd913
Compare
Choose a tag to compare
Provide Diff for new apps (#18)

* Initial commit of "Provide Diff for new apps"
* Delete temp app after diff
* Nest ArgoCD configuration keys under one key.
* Add configuration key to toggle this feature
* Add some feature limitation to docs
* Use prBtanch for temp app object TargetRevision

v0.3.0

22 Jul 14:32
322cad1
Compare
Choose a tag to compare
Allow selectively redacting diff content  (#19)

* Add a new component-level "disableDiff" configuration key
* Read the configuration file before diff
* Pass the the config the relevant function
* Replace diff content with a relevant message
* Document new configuration key


Co-authored-by: Yazdan Mohammadi <[email protected]>

---------

Co-authored-by: Yazdan Mohammadi <[email protected]>