[Bug] Fix incorrect error handling

[phoenixpereira]

Description of the Bug

When making an invalid API request or a request for a course id that doesn't exist, it returns a response code of 500.

Reproduction Steps

Send a request to https://courses-api.csclub.org.au/subjects or https://courses-api.csclub.org.au/courses/aaa.

Expected Behaviour

When making an invalid API request, it should return a response code of 400 instead of 500. Similarly, requests with a non-existing course id should return 404 instead of 500.

Additional Notes

For some reason, restarting the Docker container temporarily fixes this issue.

[rohitkrsoni]

Hi @phoenixpereira and @SouthernPolaris , I think the issue lies in here at line 345, as course.course_id is getting accessed before the exception is raised even though course could be null.

courses-api/src/server.py

Lines 334 to 349 in 18d1ca2

	def get_course(course_cid: str, db: Session = Depends(get_db)):
	"""Course details route, takes in an id returns the courses' info and classes.
	Args:
	course_cid (string, required): The id to search for.
	Returns:
	dict: A dictionary containing the course information and classes.
	"""
	course = db.query(Course).filter(Course.id == course_cid).first()
	course_id = course.course_id
	if not course:
	raise HTTPException(status_code=404, detail="Course not found")

Let me know if I can work on this issue, will check it on my local for subjects and courses

thanks,
Rohit

[phoenixpereira]

Hi @phoenixpereira and @SouthernPolaris , I think the issue lies in here at line 345, as course.course_id is getting accessed before the exception is raised even though course could be null.

courses-api/src/server.py

Lines 334 to 349 in 18d1ca2

def get_course(course_cid: str, db: Session = Depends(get_db)):
"""Course details route, takes in an id returns the courses' info and classes.

 Args: 
     course_cid (string, required): The id to search for. 

 Returns: 
     dict: A dictionary containing the course information and classes. 
 """ 
 course = db.query(Course).filter(Course.id == course_cid).first() 

 course_id = course.course_id 

 if not course: 
     raise HTTPException(status_code=404, detail="Course not found") 

Let me know if I can work on this issue, will check it on my local for subjects and courses

thanks, Rohit

@rohitkrsoni Yeah that might be it, if can you fix it that will be great!

[rohitkrsoni]

PR: #69, someone please review it, thanks